Draft
Conversation
roman-tiukh
requested changes
May 11, 2021
src/components/nav/TopBar.jsx
Outdated
Comment on lines
35
to
42
| const checkIntInCrumb = () => { | ||
| breadcrumbsNodes.forEach((item) => { | ||
| if (!Number.isNaN(parseInt(item.name, 10))) { | ||
| item.name = <LoadingIcon icon="three-dots" className="w-8 h-8" />; | ||
| } | ||
| }); | ||
| }; | ||
| checkIntInCrumb(); |
Contributor
There was a problem hiding this comment.
- You did an extra iteration over the array that can be avoided
- The icon must be added not to the data that gets into redux, but to the stage of rendering the react components
- Why did you create the function?
roman-tiukh
requested changes
May 18, 2021
Contributor
roman-tiukh
left a comment
roman-tiukh
left a comment
There was a problem hiding this comment.
- uncompleted
- uncompleted
- completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reworked breadcrumbs and added css to them