Spm brain #2
Open
Spm brain #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated .gitignore for SPM - updated Package.swift and set 5.3 as minimum required version. - tweaked IGListCompatibility header imports with TARGET_OS_MACCATALYST so we can build for mac Catalyst.
- support for macCatalyst - changed internal imports to use double quotes instead of angel brackets.
- tweaked imports to workaround swiftPM limitations. - IGListKit already module builds with IGListDiffKit sources and not use it as a separate module dependency. It allows us to avoid "#include<> " mess and keep project structure so cocoapods/carthage/xcode tests should just works. - added USE_SWIFT_PACKAGE_FROM_XCODE to proper support case where swift package was imported as the dependency to Xcode project (using build in support).
# Conflicts: # IGListKit.xcodeproj/project.pbxproj # Package.swift # Source/IGListKit/IGListKit.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.