Fix Issue in with paging on table#734
Draft
3squared-tommcgurrin wants to merge 2 commits intomainfrom
Draft
Conversation
Collaborator
3squared-tommcgurrin
commented
Feb 27, 2025
- Assign a value to "first" in table component. This holds the value of the initial row index and allows us manipulte the page index. Doing this allows us to reset the index and therefore the page index back to zero when changing the page size. Without this someone could be on page 2 with a page size of 10, change the page size to 20 and be stuck on a page that has nothing to display.
- Assign a value to "first" in table component. This holds the value of the initial row index and allows us manipulte the page index. Doing this allows us to reset the index and therefore the page index back to zero when changing the page size. Without this someone could be on page 2 with a page size of 10, change the page size to 20 and be stuck on a page that has nothing to display.
|
Change logic so it actually sets page based on current row index/ new page size
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.