Skip to content

perf: reuse SecureRandom instance in MockLnServer #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcheeric merged 4 commits into from
Nov 2, 2025
Merged

perf: reuse SecureRandom instance in MockLnServer #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a87c076
Initial plan
Copilot Nov 2, 2025
bf18f85
refactor: make SecureRandom a static final field in MockLnServer
Copilot Nov 2, 2025
393ca19
chore: fix .gitignore to exclude all target directories
Copilot Nov 2, 2025
86ce966
Merge branch 'release/0.1.4' into copilot/sub-pr-57
tcheeric Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/target/
target/
4 changes: 2 additions & 2 deletions phoenixd-mock/src/main/java/xyz/tcheeric/phoenixd/mock/MockLnServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,12 @@ private String generateValidBolt11Invoice() {

// Generate random payment hash (32 bytes = 52 chars in bech32, roughly)
// For a minimal valid invoice, we need at least timestamp + payment hash
SecureRandom random = new SecureRandom();
// Bech32 charset: qpzry9x8gf2tvdw0s3jn54khce6mua7l
StringBuilder data = new StringBuilder();

// Generate 52 random bech32 characters (represents ~32 bytes of data)
for (int i = 0; i < 52; i++) {
data.append(BECH32_CHARSET.charAt(random.nextInt(BECH32_CHARSET.length())));
data.append(charset.charAt(SECURE_RANDOM.nextInt(charset.length())));
}

// Calculate and append Bech32 checksum (6 characters)
Expand Down
Loading