Enhancement/gsdm 169/pdfkit removal #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the PSPDFKit library completely from all three apps (teacher, student, and parent) in the Canvas Android project. The removal includes dependency configurations, annotation-related classes, PDF viewing functionality, and UI components related to PDF annotation features.
Key Changes:
- Dependency removal: PSPDFKit removed from build.gradle files across all modules and Maven repository configuration removed
- Code deletion: Complete removal of PSPDFKit-related classes including annotation converters, comment fragments, and PDF-specific views
- String resource cleanup: Removal of PSPDFKit-specific string resources across all locales (40+ language files)
- UI/theme cleanup: Removal of PSPDFKit theme configurations and UI components from layouts and styles
Reviewed changes
Copilot reviewed 96 out of 96 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/build.gradle | Removed PSPDFKit Maven repository configuration |
| apps/buildSrc/src/main/java/GlobalDependencies.kt | Removed PSPDFKit version constant and dependency declaration |
| apps/teacher/build.gradle | Removed PSPDFKit license key build config field |
| apps/teacher/proguard-rules.txt | Removed PSPDFKit ProGuard rules |
| apps/teacher/src/main/AndroidManifest.xml | Removed SpeedGraderActivity with PSPDFKit theme |
| apps/teacher/src/main/res/values*.xml | Removed PSPDFKit theme styles and related UI styling |
| apps/teacher/src/main/res/layout/*.xml | Removed PSPDFKit UI coordinator layouts from submission views |
| apps/teacher/src/main/java/.../SubmissionContentView.kt | Removed PDF submission handling, annotation listeners, and related functionality |
| apps/teacher/src/main/java/.../fragments/*.kt | Commented out PSPDFKit-related event handlers and removed PDF fragment usage |
| apps/teacher/src/main/java/.../PSPDFKit/**/*.kt | Deleted all annotation comment-related classes |
| apps/teacher/src/main/java/.../utils/*.kt | Removed PSPDFKit initialization and imports |
| apps/student/src/main/java/.../AnnotationComments/*.kt | Deleted student app annotation comment classes |
| apps/student/src/androidTest/.../PdfInteractionTest.kt | Removed test for PSPDFKit annotation toolbar |
| apps/parent/src/main/java/.../AppManager.kt | Commented out Pendo initialization (appears unintentional) |
| apps/parent/proguard-rules.txt | Removed PSPDFKit ProGuard rules |
| libs/annotations/build.gradle | Removed PSPDFKit dependency and Maven repository |
| libs/annotations/src/main/java/**/*.kt | Deleted annotation converter, PDF menu grouping, and document listener classes |
| libs/annotations/src/main/res/values*/strings.xml | Removed PSPDFKit-specific strings across all localizations |
| libs/pandautils/src/main/java/.../OpenMediaAsyncTaskLoader.kt | Removed PDF-specific intent handling condition |
| libs/pandautils/src/main/java/.../AnalyticsConsts.kt | Removed PSPDFKit screen view constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/teacher/src/main/java/com/instructure/teacher/fragments/SpeedGraderGradeFragment.kt
Show resolved
Hide resolved
...teacher/src/main/java/com/instructure/teacher/fragments/SpeedGraderQuizSubmissionFragment.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://2u-internal.atlassian.net/browse/GSDM-169
Removed PSPDF Kit library from complete project including teacher and parent builds along with student build