Enhancement/gsdm 169/pdfkit removal #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed PDFKit implementation to open submitted pdfs * Removed PDF Activity class * updated * Updated PDF Submission * Update mobile-offline-downloader-android * minor update * Update strings.xml * removed pdfkit references from student module * Update libs/annotations/src/main/java/com/instructure/annotations/PDFUtils.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update apps/student/src/main/res/values/styles.xml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update apps/student/src/main/java/com/instructure/student/mobius/assignmentDetails/submissionDetails/content/PdfStudentSubmissionView.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update libs/annotations/src/main/java/com/instructure/annotations/PDFUtils.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * updated pdf download calls * updated PDFUtils * Code cleanup * Update PdfSubmissionView.kt * Update libs/annotations/src/main/java/com/instructure/annotations/PDFUtils.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update apps/student/src/main/res/values/styles.xml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update libs/annotations/src/main/java/com/instructure/annotations/PDFUtils.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * pdf minor text update * Update PDFUtils.kt * updated version * Update OfflineDependencies.kt --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the PSPDFKit library dependency and implements a simpler approach for handling PDF files by delegating viewing to external PDF viewer applications on the device.
Key changes:
- Removed PSPDFKit library dependency and all related configuration
- Replaced PDF annotation functionality with external app delegation
- Added new utility class
PDFUtilsfor PDF download and opening - Updated DocSession model to include new
pdfjsfield - Removed extensive annotation-related code, fragments, and UI components
Reviewed changes
Copilot reviewed 123 out of 124 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/annotations/src/main/java/com/instructure/annotations/PdfSubmissionView.kt | Simplified from complex annotation view to basic PDF download/open functionality |
| libs/annotations/src/main/java/com/instructure/annotations/PDFUtils.kt | New utility class for downloading and opening PDFs with external apps |
| libs/canvas-api-2/src/main/java/com/instructure/canvasapi2/models/DocSession.kt | Added pdfjs field and reformatted existing fields |
| libs/annotations/build.gradle | Removed PSPDFKit Maven repository and dependency |
| apps/teacher/src/main/java/com/instructure/teacher/view/SubmissionContentView.kt | Removed extensive annotation and PSPDFKit integration code |
| apps/student/src/main/java/com/instructure/student/mobius/assignmentDetails/submissionDetails/content/PdfStudentSubmissionView.kt | Simplified to use external PDF viewer instead of embedded PSPDFKit |
| Multiple string resource files | Removed PSPDFKit-specific strings, added new strings for external PDF viewing |
| Multiple style/theme files | Removed PSPDFKit theme configurations |
| libs/pandautils/src/main/java/com/instructure/pandautils/loaders/OpenMediaAsyncTaskLoader.kt | Removed special handling for PDF mime type |
| apps/buildSrc/src/main/java/GlobalDependencies.kt | Removed PSPDFKit version constant and library dependency |
Comments suppressed due to low confidence (1)
libs/annotations/src/main/java/com/instructure/annotations/PDFUtils.kt:1
- The error message is hardcoded in English. Consider using the string resource
R.string.noPDFViewerFoundthat was added in this PR for proper localization support.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (isUploading && submission.errorFlag) { | ||
| data.value?.attempts = attempts?.toMutableList()?.apply { | ||
| if (isNotEmpty()) removeFirst() | ||
| if (isNotEmpty()) removeAt(0) |
There was a problem hiding this comment.
The change from removeFirst() to removeAt(0) appears unrelated to the PR's purpose of removing PSPDFKit. While functionally equivalent, this change should either be part of a separate refactoring PR or explained in the PR description.
Suggested change
| if (isNotEmpty()) removeAt(0) | |
| if (isNotEmpty()) removeFirst() |
| private fun initPendo() { | ||
| val options = Pendo.PendoOptions.Builder().setJetpackComposeBeta(true).build() | ||
| Pendo.setup(this, BuildConfig.PENDO_TOKEN, options, null) | ||
| // Pendo.setup(this, BuildConfig.PENDO_TOKEN, options, null) |
There was a problem hiding this comment.
Commenting out the Pendo initialization is unrelated to PDF/PSPDFKit removal and should not be part of this PR. This could break analytics functionality in the parent app.
Suggested change
| // Pendo.setup(this, BuildConfig.PENDO_TOKEN, options, null) | |
| Pendo.setup(this, BuildConfig.PENDO_TOKEN, options, null) |
| @@ -1,7 +1,5 @@ | |||
| /* Top-level project modules */ | |||
| include ':student' | |||
There was a problem hiding this comment.
Removing the teacher and parent module includes will break the build for those apps. This change appears to be accidental and unrelated to PSPDFKit removal.
Suggested change
| include ':student' | |
| include ':student' | |
| include ':teacher' | |
| include ':parent' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://2u-internal.atlassian.net/browse/GSDM-169
Removed PSPDF Kit library from complete project including teacher and parent builds along with student build