Skip to content

Conversation

@srajupusapati
Copy link
Contributor

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow for staging builds and updates the git submodule configuration to use HTTPS instead of SSH for the mobile-offline-downloader-android repository.

  • Introduces a new staging CI workflow that builds Android APKs and distributes them via Firebase
  • Converts submodule URL from SSH to HTTPS for better CI/CD compatibility
  • Removes the unused android-vault submodule reference

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File Description
.gitmodules Removes android-vault submodule and converts mobile-offline-downloader-android URL from SSH to HTTPS
.github/workflows/Staging.yml Adds complete staging workflow with build, test, and Firebase distribution capabilities

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 96 to 97
sed -i "s/const val versionCode = [0-9]\+/const val versionCode = $VERSION_CODE/" buildSrc/src/main/java/Dependencies.kt
sed -i 's/const val versionName = "[^"]*"/const val versionName = "'"$VERSION_NAME"'"/' buildSrc/src/main/java/Dependencies.kt
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sed commands are modifying Dependencies.kt but the file path references 'buildSrc/src/main/java/Dependencies.kt' without the 'apps/' prefix that's used in other steps (see line 81 'cd apps'). This inconsistency suggests the working directory context may be incorrect, potentially causing the version updates to fail silently.

Suggested change
sed -i "s/const val versionCode = [0-9]\+/const val versionCode = $VERSION_CODE/" buildSrc/src/main/java/Dependencies.kt
sed -i 's/const val versionName = "[^"]*"/const val versionName = "'"$VERSION_NAME"'"/' buildSrc/src/main/java/Dependencies.kt
sed -i "s/const val versionCode = [0-9]\+/const val versionCode = $VERSION_CODE/" apps/buildSrc/src/main/java/Dependencies.kt
sed -i 's/const val versionName = "[^"]*"/const val versionName = "'"$VERSION_NAME"'"/' apps/buildSrc/src/main/java/Dependencies.kt

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 21, 2025 11:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +113 to +114
app/build/test-results
app/build/reports/tests
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths reference 'app/build/' but the build is executed in 'apps/student/build/'. The correct paths should be 'apps/student/build/test-results' and 'apps/student/build/reports/tests'.

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings October 21, 2025 12:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@sghosh-sonata-rgb sghosh-sonata-rgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved.

@sghosh-sonata-rgb sghosh-sonata-rgb merged commit a5efb79 into master Oct 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants