-
Notifications
You must be signed in to change notification settings - Fork 0
Gsdm 41: Add Github Actions for Staging #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a GitHub Actions workflow for staging builds and updates the git submodule configuration to use HTTPS instead of SSH for the mobile-offline-downloader-android repository.
- Introduces a new staging CI workflow that builds Android APKs and distributes them via Firebase
- Converts submodule URL from SSH to HTTPS for better CI/CD compatibility
- Removes the unused android-vault submodule reference
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| .gitmodules | Removes android-vault submodule and converts mobile-offline-downloader-android URL from SSH to HTTPS |
| .github/workflows/Staging.yml | Adds complete staging workflow with build, test, and Firebase distribution capabilities |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.github/workflows/Staging.yml
Outdated
| sed -i "s/const val versionCode = [0-9]\+/const val versionCode = $VERSION_CODE/" buildSrc/src/main/java/Dependencies.kt | ||
| sed -i 's/const val versionName = "[^"]*"/const val versionName = "'"$VERSION_NAME"'"/' buildSrc/src/main/java/Dependencies.kt |
Copilot
AI
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sed commands are modifying Dependencies.kt but the file path references 'buildSrc/src/main/java/Dependencies.kt' without the 'apps/' prefix that's used in other steps (see line 81 'cd apps'). This inconsistency suggests the working directory context may be incorrect, potentially causing the version updates to fail silently.
| sed -i "s/const val versionCode = [0-9]\+/const val versionCode = $VERSION_CODE/" buildSrc/src/main/java/Dependencies.kt | |
| sed -i 's/const val versionName = "[^"]*"/const val versionName = "'"$VERSION_NAME"'"/' buildSrc/src/main/java/Dependencies.kt | |
| sed -i "s/const val versionCode = [0-9]\+/const val versionCode = $VERSION_CODE/" apps/buildSrc/src/main/java/Dependencies.kt | |
| sed -i 's/const val versionName = "[^"]*"/const val versionName = "'"$VERSION_NAME"'"/' apps/buildSrc/src/main/java/Dependencies.kt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| app/build/test-results | ||
| app/build/reports/tests |
Copilot
AI
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paths reference 'app/build/' but the build is executed in 'apps/student/build/'. The correct paths should be 'apps/student/build/test-results' and 'apps/student/build/reports/tests'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sghosh-sonata-rgb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved.
Jira: https://2u-internal.atlassian.net/browse/GSDM-41