feat: replace app icon with Big Sur style design#232
Merged
Conversation
Replace the outdated photorealistic gas mask icon with the community-contributed Big Sur rounded-rectangle icon from issue #203. Icon assets are cherry-picked from PR #220 which bundled the icon update with many other changes. Changes: - Add AppIcon.appiconset to asset catalog with all size variants (16-1024px) - Add AboutIcon.imageset and menuIcon.imageset to asset catalog - Update hosts.icns document type icon and help page icon - Migrate from legacy CFBundleIconFile (.icns) to ASSETCATALOG_COMPILER_APPICON_NAME - Remove dead pre-10.10 code paths in Menulet.m (deployment target is macOS 13.0) - Delete legacy icon files (applicationIcon.icns, About Box Image.png, menuIcon TIFFs) Icon by @chrissy-dev, drawn from scratch with no licensing issues. Closes #203
- Remove redundant [icon setTemplate:YES] in Menulet.m since the asset catalog already declares template-rendering-intent - Remove unused 3x scale entries from AboutIcon and menuIcon imagesets (macOS only uses 1x and 2x) - Delete backing files icon_512x512.png and menuIcon@3x.png
2ndalpha
added a commit
that referenced
this pull request
Feb 28, 2026
The rebase onto master picked up menuIcon.tiff references that were deleted by #232 (app icon migration to asset catalog). Remove the orphaned PBXBuildFile, PBXFileReference, and Resources build phase entries for menuIcon.tiff and menuIcon@2x.tiff.
2ndalpha
added a commit
that referenced
this pull request
Feb 28, 2026
* feat: replace Preferences window with SwiftUI (#231) Migrate the Preferences window from ObjC/XIB to SwiftUI, following the same pattern used for URLSheet in PR #227. - Replace PreferenceController (ObjC) + Preferences.xib with a SwiftUI-based presenter using NSTabViewController for proper macOS toolbar-style tab icons - Add 5 SwiftUI tab views: General, Editor, Remote, Hotkeys, Update - Use SF Symbols for tab icons (gearshape, square.and.pencil, globe, command.square.fill, arrow.triangle.2.circlepath) - Bridge ShortcutRecorder via NSViewRepresentable for hotkey recording - Wrap SUUpdater and LoginItem in ObservableObject for SwiftUI binding - Add RemoteIntervalMapper for clean slider-to-minutes conversion - Remove unused preference icon PNGs and old ObjC files - Add PreferencesPresenter tests (window creation, reuse, tabs, icons) - Uniform tab content size prevents window resizing on tab switch * fix: address code review findings for Preferences SwiftUI migration - Use Sparkle public API for reading automaticChecksEnabled instead of hardcoding the UserDefaults key - Guard screenshot test against headless CI with XCTSkipIf and remove NSScreen.main force unwrap * fix: remove stale menuIcon.tiff references from pbxproj The rebase onto master picked up menuIcon.tiff references that were deleted by #232 (app icon migration to asset catalog). Remove the orphaned PBXBuildFile, PBXFileReference, and Resources build phase entries for menuIcon.tiff and menuIcon@2x.tiff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the outdated photorealistic gas mask icon with the community-contributed Big Sur rounded-rectangle icon from #203. Icon assets cherry-picked from #220.
Changes
AppIcon.appiconset,AboutIcon.imageset, andmenuIcon.imagesetto asset catalog.icnstoASSETCATALOG_COMPILER_APPICON_NAMEhosts.icns, help page icon, and About Box image referenceMenulet.m(deployment target is macOS 13.0)applicationIcon.icns,About Box Image.png,menuIconTIFFs)Icon by @chrissy-dev — drawn from scratch, no licensing issues.
Screenshots
App icon
Status bar icon
About Box icon
Help page icon
Test plan
.hstdocument icon all display correctlyCloses #203