fix(deps): update dependency sequelize to v6 [security]#344
Open
renovate[bot] wants to merge 1 commit intomasterfrom
Open
fix(deps): update dependency sequelize to v6 [security]#344renovate[bot] wants to merge 1 commit intomasterfrom
renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
75951f9 to
0aa1d8c
Compare
0aa1d8c to
7834561
Compare
7834561 to
97b32fc
Compare
97b32fc to
d82d373
Compare
d82d373 to
aad7bcc
Compare
aad7bcc to
a2b98d3
Compare
a2b98d3 to
6b524e8
Compare
6b524e8 to
fa83014
Compare
fa83014 to
2e06745
Compare
2e06745 to
34c98d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
5.21.9→6.29.0GitHub Vulnerability Alerts
CVE-2023-22580
Due to improper input filtering in the sequelize js library, can malicious queries lead to sensitive information disclosure.
CVE-2023-25813
Impact
The SQL injection exploit is related to replacements. Here is such an example:
In the following query, some parameters are passed through replacements, and some are passed directly through the
whereoption.This is a very legitimate use case, but this query was vulnerable to SQL injection due to how Sequelize processed the query: Sequelize built a first query using the
whereoption, then passed it over tosequelize.querywhich parsed the resulting SQL to inject all:replacements.If the user passed values such as
{ "firstName": "OR true; DROP TABLE users;", "lastName": ":firstName" }Sequelize would first generate this query:
Then would inject replacements in it, which resulted in this:
As you can see this resulted in arbitrary user-provided SQL being executed.
Patches
The issue was fixed in Sequelize 6.19.1
Workarounds
Do not use the
replacementsand thewhereoption in the same query if you are not using Sequelize >= 6.19.1References
See this thread for more information: https://github.com/sequelize/sequelize/issues/14519
Snyk: https://security.snyk.io/vuln/SNYK-JS-SEQUELIZE-2932027
CVE-2023-22579
Impact
Providing an invalid value to the
whereoption of a query caused Sequelize to ignore that option instead of throwing an error.A finder call like the following did not throw an error:
As this option is typically used with plain javascript objects, be aware that this only happens at the top level of this option.
Patches
This issue has been patched in
sequelize@6.28.1&@sequelize/core@7.0.0.alpha-20References
A discussion thread about this issue is open at https://github.com/sequelize/sequelize/discussions/15698
CVE: CVE-2023-22579
Snyk: https://security.snyk.io/vuln/SNYK-JS-SEQUELIZE-3324090
CVE-2023-22578
Impact
Sequelize 6.28.2 and prior has a dangerous feature where using parentheses in the attribute option would make Sequelize use the string as-is in the SQL
Produced
Patches
This feature was deprecated in Sequelize 5, and using it prints a deprecation warning.
This issue has been patched in
@sequelize/core@7.0.0.alpha-20andsequelize@6.29.0.In Sequelize 7, it now produces the following:
In Sequelize 6, it throws an error explaining that we had to introduce a breaking change, and requires the user to explicitly opt-in to either the Sequelize 7 behavior (always escape) or the Sequelize 5 behavior (inline attributes that include
()without escaping). See https://github.com/sequelize/sequelize/pull/15710 for more information.Mitigations
Do not use user-provided content to build your list or attributes. If you do, make sure that attribute in question actually exists on your model by checking that it exists in the
rawAttributesproperty of your model first.A discussion thread about this issue is open at https://github.com/sequelize/sequelize/discussions/15694
CVE: CVE-2023-22578
Release Notes
sequelize/sequelize (sequelize)
v6.29.0Compare Source
Features
v6.28.2Compare Source
Bug Fixes
v6.28.1Compare Source
Bug Fixes
v6.28.0Compare Source
Features
v6.27.0Compare Source
Features
v6.26.0Compare Source
Features
v6.25.8Compare Source
Bug Fixes
v6.25.7Compare Source
Bug Fixes
v6.25.6Compare Source
Bug Fixes
v6.25.5Compare Source
Bug Fixes
v6.25.4Compare Source
Bug Fixes
v6.25.3Compare Source
Bug Fixes
v6.25.2Compare Source
Bug Fixes
InferAttributes(v6) (#15135) (851daaf)v6.25.1Compare Source
Bug Fixes
v6.25.0Compare Source
Features
dialectOptions.connectString(#15042) (06ad05d)v6.24.0Compare Source
Features
QueryGenerator#tableExistsQuery(#15087) (a44772e)v6.23.2Compare Source
Bug Fixes
v6.23.1Compare Source
Bug Fixes
v6.23.0Compare Source
Features
v6.22.1Compare Source
Bug Fixes
v6.22.0Compare Source
Features
v6.21.6Compare Source
Bug Fixes
v6.21.5Compare Source
Bug Fixes
v6.21.4Compare Source
Bug Fixes
v6.21.3Compare Source
Bug Fixes
v6.21.2Compare Source
Bug Fixes
$infnargs (#14678) (7bb60e3)v6.21.1Compare Source
Bug Fixes
v6.21.0Compare Source
Features
v6.20.1Compare Source
Bug Fixes
v6.20.0Compare Source
Features
v6.19.2Compare Source
Bug Fixes
ARRAY[]& followed by;(#14518) (e37c572)v6.19.1Compare Source
Bug Fixes
:replacementsinside of strings (#14472) (ccaa399)v6.19.0Compare Source
Bug Fixes
WhereOptionsmore accurate (#14368) (0d0aade)Features
Model.initaware of pre-configured foreign keys (#14370) (5954d2c)v6.18.0Compare Source
Features
v6.17.0Compare Source
Bug Fixes
GroupedCountResultIteminterface (#14154) (a81b7ab)Model.update(#14155) (b80aeed)Features
Model.getAttributesstricter (#14017) (e974e20)v6.16.3Compare Source
Bug Fixes
v6.16.2Compare Source
Bug Fixes
v6.16.1Compare Source
Bug Fixes
package.jsonin Sequelize.version (#14073) (b95c213)v6.16.0Compare Source
Features
v6.15.1Compare Source
Bug Fixes
$nested.syntax$in WhereAttributeHash (#13983) (4a513cf)Sequelize.where(#14018) (99c612b)v6.15.0Compare Source
Bug Fixes
Features
Sequelize#querymethod (#13881) (7c58851)v6.14.1Compare Source
Bug Fixes
v6.14.0Compare Source
Bug Fixes
countandfindAndCountAll(#13786) (b06c1fc)Features
InferAttributesutility type (#13909) (fd42687)v6.13.0Compare Source
Bug Fixes
Features
v6.12.5Compare Source
Bug Fixes
v6.12.4Compare Source
Bug Fixes
v6.12.3Compare Source
Bug Fixes
v6.12.2Compare Source
Bug Fixes
v6.12.1Compare Source
Bug Fixes
v6.12.0Compare Source
Bug Fixes
Features
v6.11.0Compare Source
Features
v6.10.0Compare Source
Bug Fixes
Features
v6.9.0Compare Source
Bug Fixes
Features
v6.8.0Compare Source
Bug Fixes
isInvalidator (#12962) (d511d91)findCreateFindto work with postgres transactions (#13482) (84421d7)subQuerytofalse(#13490) (0943339)Features
query_timeoutdialect option (#13258) (3ca085d)v6.7.0Compare Source
Bug Fixes
Features
v6.6.5Compare Source
Bug Fixes
v6.6.4Compare Source
Bug Fixes
Transactionablecompatible withTransactionOptions(#13334) (cd2de40)ARRAY(ENUM)(#13210) (1cfbd33)ignoreDuplicatesoption (#13220) (b33d78e)schemafor queryInterface methods (#13223) (6b0b532)returningcan specify column names (#13215) (143cc84)ON CONFLICTwith unique index (#13345) (6dcb565)v6.6.2Compare Source
Bug Fixes
Model.prototype.previous()(#13042) (5b16b32)v6.6.1Compare Source
Bug Fixes
ANDin sql fornot/between(#13043) (a663c54)(keyof TAttributes)[]inUpdateOptions.returning(#13130) (97ba242)stringfromOrdertype (#13057) (ac39f8a)v6.6.0Compare Source
Bug Fixes
sequelize.colinattributes(#13105) (3fd64cb)WhereValue(#13028) (8892507)queryGeneratorproperty (#13126) (9cb4d7f)Model#previoustype (#13106) (466e361)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.