Implement #4, minor cleanups #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed fabric api, as it is unused, and changed fabric language kotlin from an included dependency, to an external dependency as it is quite large. Also removed fabric-api-base as an included dependency, and added fabric-api as an external dependency. Fabric-api is a common dependency so it is most likely already installed.
Replace the kotlin introduction message with a pure java implementation that is just as concise. This eliminates the need for an extra library that the user has to think about.
Changes item names to be non-italic when applying a custom formatting. Examples: Item name: "Name" will still be italic Item name: "<red>Name" will be red and not italic Item name: "<i><red>Name" will be red and italic Item name: "<reset>Name" will still be italic, this is an issue with the detection method. Item name: "<white>Name" will not be italic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Allow item names to be non-italic #4
Item name:
Namewill still be italicItem name:
<red>Namewill be red and not italicItem name:
<i><red>Namewill be red and italicItem name:
<reset>Namewill still be italic, this is an issue with the detection method.Item name:
<white>Namewill not be italicRemove the kotlin dependency, replcace the welcome message with vanilla java for easier mod installation
bump dependency versions
add fabric api as a dependency (the fabric-api-base could also be included in the built .jar file, but since most people already have the fabric-api installed anyways, it is unnecessary)
mark the game version as 1.20-1.20.1, as 1.20.2 and 1.20.4 need different versions of PlaceholderAPI
update gradle to 8.5, as at least 8.3 is needed for fabric-loom 1.5-SNAPSHOT (gradle was on version 8.1.1 before)