Draft
Conversation
b-rowan
reviewed
Feb 2, 2026
| } | ||
| }); | ||
| // Protocol detection based on URL scheme | ||
| if pool_url.starts_with("sv2+tcp://") { |
Member
There was a problem hiding this comment.
AFAIU this can be stratum2+tcp in some cases (see https://academy.braiins.com/en/braiins-pool/stratum-v2-manual/, URL is stratum2+tcp://stratum.braiins.com:3333/9awtMD5KQgvRUh2yFbjVeT7b6hjipWcAsQHd6wEhgtDT9soosna there).
Not sure if this is ALL cases, but certainly should be supported.
Collaborator
Author
There was a problem hiding this comment.
I'll update shortly to fix the url and propose a more concrete PR.
There was a problem hiding this comment.
this link is indeed the only reference on this on the spec
and yeah, this is the correct scheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked as draft because it's all vibes at this point but I was able to run and submit shares using https://github.com/stratum-mining/sv2-apps and a BitAxe 602 with the raw firmware.
