Skip to content

Fix map bounds check in movementSystem #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RodionovMaxim05 merged 1 commit into from
Dec 6, 2025
Merged

Fix map bounds check in movementSystem #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions engine/ecs/systems.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ void movementSystem(entt::registry &registry, std::vector<engine::Tile> &tiles,
sf::Vector2f delta = vel.value * speed.value * dt;

auto canMove = [&](float newX, float newY) {
int tileX = static_cast<int>(newX) - 1;
int tileY = static_cast<int>(newY);
int tileX = static_cast<int>(std::floor(newX)) - 1;
int tileY = static_cast<int>(std::floor(newY));
if (tileX < 0 || tileX >= worldWidth || tileY < 0 ||
tileY >= worldHeight)
return false;
Expand Down