Add common Webpack Build Config for NextJS projects and Storybook for a shared SVGR integration.#37
Open
keichinger wants to merge 3 commits into2.xfrom
Open
Add common Webpack Build Config for NextJS projects and Storybook for a shared SVGR integration.#37keichinger wants to merge 3 commits into2.xfrom
keichinger wants to merge 3 commits into2.xfrom
Conversation
apfelbox
reviewed
May 24, 2024
| @@ -1,4 +1,4 @@ | |||
| exports.registerSvgWebpackLoader = (config) => | |||
| export const registerSvgWebpackLoader = (config) => | |||
Member
There was a problem hiding this comment.
We should write it as TS now, so we don't need any new infrastructure.
Type-wise that might get hard, but using simplified types here is fine.
apfelbox
reviewed
May 24, 2024
| export const registerSvgWebpackLoader = (config) => | ||
| { | ||
| // Grab the existing rule that handles SVG imports | ||
| const fileLoaderRule = config.module.rules.find((rule) => rule.test?.test?.(".svg") && rule.resourceQuery?.toString() !== "/raw/"); |
Member
There was a problem hiding this comment.
I don't remember the deal about the /raw/?
apfelbox
requested changes
May 24, 2024
| // Grab the existing rule that handles SVG imports | ||
| const fileLoaderRule = config.module.rules.find((rule) => rule.test?.test?.(".svg") && rule.resourceQuery?.toString() !== "/raw/"); | ||
| // Modify the file loader rule to ignore *.svg, since we have it handled now. | ||
| fileLoaderRule.exclude = /\.svg$/i; |
Member
There was a problem hiding this comment.
We should
- add this
excludeto every rule, not just the first we find (there might be multiple ones) - should merge the
excludewith a maybe existingexclude - find out why we tested for
/raw/above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.