Make MessageGenerator infallible#521
Merged
rustaceanrob merged 3 commits into2140-dev:masterfrom Nov 22, 2025
Merged
Conversation
rustaceanrob
force-pushed
the
11-20-network-cleanup
branch
from
fedcabe to
8973538
Compare
nyonson
approved these changes
Nov 21, 2025
Collaborator
nyonson
left a comment
nyonson
left a comment
There was a problem hiding this comment.
The two expect's in the first patch make sense to me.
The in-memory buffer cannot fail when serializing a message, and the encryption cannot fail when memory is know as well.
Use `serialize` to remove some of the code bloat in `outbound_messages`.
Because the modules are in the `network` subspace using `inbound/outbound` implies what is going back and forth (network messages).
rustaceanrob
force-pushed
the
11-20-network-cleanup
branch
from
8973538 to
d7db51c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-memory buffer cannot fail when serializing a message, and the encryption cannot fail when memory is know as well.
@nyonson can I get a sanity check on the new
expectconditions in the first commit? If I remember correctly theserdeimplementation should be infallible because we are only working with vectors, and theOutboundCipher::encrypt_to_vecis also infallible now inbip324