Closed
Conversation
As of Rust lang `1.0.0` the `&[u8]` type does not include any error cases in the `Read::read` function. The bip158 module of `rust-bitcoin` involves a lot of propagation, but ultimately the fallible function is `Read::read` on a slice. Removing the error case allows for a cleaner API both internally and externally for future silent payments users. Read trait invokation: https://docs.rs/bitcoin/latest/src/bitcoin/bip158.rs.html#455 The buffer: https://docs.rs/bitcoin/latest/src/bitcoin/bip158.rs.html#470 Read implemented for `&[u8]`: https://doc.rust-lang.org/src/std/io/impls.rs.html#298-403
rustaceanrob
changed the title
match_anymatch_any
Collaborator
Author
|
Shoot. I thought the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Rust lang
1.0.0the&[u8]type does not include any error cases in theRead::readfunction (instead there are panics). The bip158 module ofrust-bitcoininvolves a lot of error propagation, but ultimately the fallible function isRead::readon a slice. Removing the error case allows for a cleaner API both internally and externally for future silent payments users.Read trait invocation: https://docs.rs/bitcoin/latest/src/bitcoin/bip158.rs.html#455
The buffer: https://docs.rs/bitcoin/latest/src/bitcoin/bip158.rs.html#470
Read implemented for
&[u8]: https://doc.rust-lang.org/src/std/io/impls.rs.html#298-403Note this is the same message in the commit so there is a reference.