Open
Conversation
2 tasks
…#60-todo-reminder # Conflicts: # src/main/java/com/project/backend/domain/reminder/service/query/ReminderQueryServiceImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☝️Issue Number
Close #60
📌 개요
aee0ed7
3447df3
9e63c2b
5df3070
365dd1c
🔁 변경 사항
aee0ed7
3447df3
9e63c2b
할 일 CUD에 따른 리마인더 생성, 삭제, 수정 로직 처리했습니다
UPDATE 로직
THIS_AND_FOLLOWING 수정 시,
DELETE 로직
THIS_TODO 삭제 시,
TodoRecurrenceException에 따른 리마인더 처리 로직을 추가했을때, jpa flush 과정에서 반복예외 delete보다 skip상태의 반복예외 insert가 먼저 실행되어 반복예외 db에서 exceptionDate 유니크 에러 발생.THIS_AND_FOLLOWING 삭제 시,
📸 스크린샷
👀 기타 더 이야기해볼 점
일정 할일 관련해서 수정사항 정리 - https://www.notion.so/CRUD-3038f1b5499880338386fab767b8f013?source=copy_link
할 일 관련 로직은 기존의 코드 최대한 유지하면서 리마인더 로직 입혀봤습니다...!
추가적으로
투두 로직 보다가 발견한 이상한 점인데,
따라서 startDate를 변경해도 변경 사항이 적용되지 않습니다!
제가 업데이트 처리할까했는데 혹시 자연어 API 로직 부분에서 많이 엮일까봐 일단 PR올렷습니다.