fix(feature) : mypage, save page, course detail map 기능 수정 & sheet 및 style 수정 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
westofsky
reviewed
Sep 25, 2025
| if (!defaultIsPickPlace) return null; | ||
|
|
||
| const foundPlace = findPlaceByName(defaultIsPickPlace); | ||
| const foundPlace = findPlaceByName(defaultIsPickPlace.split(' ')[1]); |
Contributor
There was a problem hiding this comment.
defaultIsPickPlace.split(' ')[1] 는 변수로 한번 정리해도 좋을 것 같습니다.
| </header> | ||
| <div className='mt-14'> | ||
| <SavePageContent /> | ||
| <SavePageContent favoriteCourses={favoriteCourses.data!} /> |
Contributor
There was a problem hiding this comment.
SavePageContent에서 null처리 하고 있지만 FavoriteCoursesByRegion타입 체크에 걸리면
Suggested change
| <SavePageContent favoriteCourses={favoriteCourses.data!} /> | |
| <SavePageContent favoriteCourses={favoriteCourses.data || []} /> |
로 처리해도 좋을 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: #
작업 내역
변경사항
PR 특이 사항
Checklist
feat(user): add login page)