Create a cryptography library that can change its backend at compile time#91
Draft
Progdrasil wants to merge 10 commits intomainfrom
Draft
Create a cryptography library that can change its backend at compile time#91Progdrasil wants to merge 10 commits intomainfrom
Progdrasil wants to merge 10 commits intomainfrom
Conversation
Comment on lines
+99
to
+100
| cred_with_uv: Rng::random_vec(32), | ||
| cred_without_uv: config.credentials.without_uv().then(|| Rng::random_vec(32)), |
Member
There was a problem hiding this comment.
Question: What is the distinction between using an RngBackend controlled by the provider (pub fn randomized for example) vs these cases where Rng is used directly?
Collaborator
Author
There was a problem hiding this comment.
None really, I started with using the Rng directly as that was easier to migrate. This PR isn't finished and hopefully the Rng will be fully behind the crypto provider by the end
started a trait tree with associated types for all of the keys and signatures
Progdrasil
force-pushed
the
passkey-crypto
branch
from
39cb7d5 to
674d2d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the
passkey-cryptocrate which houses the newBackendseries of traits to allow Authenticator (and others) to call the trait methods rather than the libraries themselves.This currently is only moving code around and implementing the traits directly on the
p256types, but by the time the MR is ready, I'll have wrapped those types up to make aRustCryptoBackendwhich can support multiple algorithms.Resolves #50, #62