Conversation
iinuwa
suggested changes
Dec 29, 2025
Contributor
iinuwa
left a comment
iinuwa
left a comment
There was a problem hiding this comment.
This looks useful! Just a couple of nits.
Progdrasil
force-pushed
the
add-passkey-accessor-trait
branch
from
8c85319 to
ec57ee0
Compare
iinuwa
approved these changes
Jan 2, 2026
Vogeltak
approved these changes
Jan 6, 2026
Collaborator
Vogeltak
left a comment
Vogeltak
left a comment
There was a problem hiding this comment.
Looks good! No blocking comments.
Progdrasil
force-pushed
the
add-passkey-accessor-trait
branch
from
ec57ee0 to
1ecc79b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This originally started out as adding
usernameanduser_display_nameto the Passkey representation struct. But then I abstracted that type away behind a newPasskeyAccessortrait so that the type provided by the store can be acted on inmake_credentialandget_assertionwithout any conversions necessary. This allows us to keep context and additional information throughout these methods. This allowsCredentialStoreandUserValidationMethodto drop explicit use ofPasskeyaltogether, keeping any additional information in the custom types between calls to the store in the same ceremony.