Make typeshare an optional dependency#68
Conversation
106150e to
2debb54
Compare
Progdrasil
left a comment
There was a problem hiding this comment.
LGTM, You'll just need to fix the pipeline
2debb54 to
1c87f46
Compare
|
Looks like we need to duplicate those two fields mentioned in the review because the I reverted back to the original code. I'll do a separate PR to fix the Clippy lints. |
|
For the cfg_attr, this will be blocked on 1Password/typeshare#273 |
|
1Password/typeshare#273 is merged, but 1Password/typeshare#274, which points to typeshare's |
|
I'll poke around internally, thanks for reminding me |
1c87f46 to
01c1d33
Compare
|
@Progdrasil done! |
Upstreaming bitwarden#14: