Handle incorrect k8s secret data keys #244
Merged
+51
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Summary
K8s throws an error if data key in k8s secret doesn't match
[-._a-zA-Z0-9]+regexp. (IsConfigMap method).The empty string
""keys are considered invalid as well.In the current implementation
formatSecretDataNamewill return empty string if the key (field or url label) contains invalid characters, for example (####or" "). Therefore it tries to add the entry into k8s secret.data with key as empty string. This leads operator to throw an error.This PR fixes this behaviour, and if
formatSecretDataNamereturns empty string (aka label was in the format that k8s doesn't support), operator will print the message in the log and skip adding the entry (field, url or file) into k8s secret.🔗 Resolves: #243
✅ Checklist
🕵️ Review Notes &⚠️ Risks