fix: icon size & support BackedEnum#38
Open
agencetwogether wants to merge 1 commit into199ocero:4.xfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the Filament icon component generates the classes
fi-iconandfi-size-{$size->value}, it's no longer necessary to use the$iconSizeClassvariable inradio-deck.blade.phpInstead, you can directly pass the desired size to size attribute of the component.
Indeed, without this fix, if the size 2xl was defined, the component's generated class remained
fi-size-mdand notfi-size-2xl. And so the icon wasn't the right size.And with the Filament CSS icon class definitions, the sizes are correctly defined.
See
filament/packages/support/resources/css/components/icon.cssfile.Furthermore, this pull request allows the use of icons with backed enums.
The readme file has been updated accordingly.
Thanks