fix: Child components receive null state when using array data with Infolist state()#41
Open
Luca-Lin wants to merge 1 commit into199ocero:3.xfrom
Open
fix: Child components receive null state when using array data with Infolist state()#41Luca-Lin wants to merge 1 commit into199ocero:3.xfrom
Luca-Lin wants to merge 1 commit into199ocero:3.xfrom
Conversation
Author
|
This is my first contribution to this project. If there are any issues with this fix, or if you have suggestions for a better approach, please let me know. I'm happy to make adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using ActivitySection with array data passed via Infolist::state(), child components (ActivityTitle, ActivityDescription, ActivityDate, ActivityIcon) receive null from their $getState() method instead of the actual data.
Environment:
Example usage that fails:
Expected behavior: Child components display the data (title, description, etc.)
Actual behavior: Child components display placeholder text because $getState() returns null
Root Cause
In ActivitySection::getChildComponentContainers(), the method sets statePath($itemKey) for each child container, but when $itemData is an array (not a Model), the state data is not properly passed to child components:
Solution
Pass the array data to child containers using state() method when the data is not a Model:
Changes