[pull] main from electron:main#5
Open
pull[bot] wants to merge 3034 commits into16CentAstrology:mainfrom
Open
Conversation
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.0 to 4.31.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4e94bd1...0499de3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: bump node in DEPS to v24.11.0 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
build: apply additional compression on upload for large files
refactor: remove base::AdaptCallbackForRepeating patch
refactor: remove unnecessary template type in EmitEvent() refactor: CallMethodWithArgs() takes a std::string_view
* refactor: remove electron::WebRequestAPI interface Remove the |electron::WebRequestAPI| interface class. Use handles to the concrete class |electron::api::WebRequest| instead. Prerequisite for #48762. Two classes (electron::ProxyingURLLoaderFactory and electron::ProxyingWebSocket) hold a handle to a WebRequest via |raw_ptr<electron::WebRequestAPI>|. |electron::WebRequestAPI| is a pure virtual interface whose concrete impl is |electron::api::WebRequest|. This is a problem when migrating |electron::api::WebRequest| to cppgc: we need to change those |raw_ptr<>|s to |cppgc::WeakPersistent<>| but can't instantiate |cppgc::WeakPersistent<electron::WebRequestAPI>| as-is. We also can't change it to inherit from |cppgc::GarbageCollectedMixin|, since that causes problems when |electron::api::WebRequest| inherits from both |electron::WebRequestAPI| and |cppgc::GarbageCollected|. * refactor: use name web_request, not web_request_api * refactor: make ProxyingURLLoaderFactory::web_request() private * chore: make linter happy by fixing whitespace
* fix: allow disabling all `NSMenuItems` (#48598) fix: allow disabling all NSMenuItems * fix: add guard for type --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
feat: add `sharedTexture` module.
refactor: remove allow_unsafe_buffers pragma from FD_ZERO
fix: CSD window frame tiles properly on Linux
* fix: enable wasm trap handlers in all Node.js processes * fix: separate registrations to account for featurelist init
* chore: bump chromium in DEPS to 144.0.7507.0 * chore: bump chromium in DEPS to 144.0.7508.0 * chore: update patches * 7101838: [pathbuilder] Enforce immutable SkPath APIs globally https://chromium-review.googlesource.com/c/chromium/src/+/7101838 * chore: update filenames.libcxx.gni * [pathbuilder] Enforce immutable SkPath APIs globally https://chromium-review.googlesource.com/c/chromium/src/+/7101838 * Reduce service_worker_info.h includes in headers https://chromium-review.googlesource.com/c/chromium/src/+/7108401 * chore: bump chromium in DEPS to 144.0.7510.0 * chore: update patches * Use internal popup menus for tabs in actor-controlled states https://chromium-review.googlesource.com/c/chromium/src/+/7074751 * [api] Delete deprecated fields on v8::Isolate https://chromium-review.googlesource.com/c/v8/v8/+/7081397 xref: nodejs/node@98d243a * Fixup Reduce service_worker_info.h includes in headers * Promote deprecation of v8::Context and v8::Object API methods https://chromium-review.googlesource.com/c/v8/v8/+/7087956 * fixup Promote deprecation of v8::Context and v8::Object API methods * chore: bump chromium in DEPS to 144.0.7512.1 * chore: update patches * fixup [pathbuilder] Enforce immutable SkPath APIs global * chore: update filenames.hunspell.gni * fix deprecation of v8::Context and v8::Object API methods for nan https://chromium-review.googlesource.com/c/v8/v8/+/7087956 * [PDF] Implement PdfHelpBubbleHandlerFactory https://chromium-review.googlesource.com/c/chromium/src/+/7056325 also: [PDF Ink Signatures] Hook up IPH https://chromium-review.googlesource.com/c/chromium/src/+/7056207 * Remove base/hash/md5.h https://chromium-review.googlesource.com/c/chromium/src/+/7113738 * fixup for lint * Remove deprecated interceptor callback types and AccessControl enum https://chromium-review.googlesource.com/c/v8/v8/+/7112747 * fixup for lint * fixup [PDF] Implement PdfHelpBubbleHandlerFactory * use base::SHA1HashString instead of std::hash --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* docs: Update 404 devtools extension documentation link https://developer.chrome.com/extensions/devtools ↑Current link is not exists. So update to most relevant developer.chrome.com page. https://developer.chrome.com/docs/extensions/how-to/devtools/extend-devtools#creating * docs: remove unnecessary anchor link Co-authored-by: Erick Zhao <erick@hotmail.ca> --------- Co-authored-by: Erick Zhao <erick@hotmail.ca>
…48843) refactor: remove spellcheck::kWinDelaySpellcheckServiceInit patch
* refactor: rename api::Session::CreateFrom() to api::Session::FromOrCreate() This is both clearer and more consistent with other classes * refactor: add Session::FromOrCreate(content::BrowserContext*) * refactor: reimplement api::WebRequest::FromOrCreate() using api::Session::FromOrCreate() * refactor: use base::PassKey to ensure WebRequest is only instantiated by Session * refactor: remove WebRequest::From() no longer needed; Session already guarantees uniqueness * refactor: remove unused isolate arg from WebRequest ctor * refactor: do not attach WebRequest to BrowserContext no longer needed now that access goes through Session
refactor: remove unused method ExtensionActionAPI::GetExtensionPrefs() refactor: remove unused field ExtensionActionAPI::browser_context_ refactor: remove unused field ExtensionActionAPI::browser_context_ looks like these were added in 5b105f9 but never used
…s opened (#48770) fix: fix the issue where the parent window remained interactive after the modal window was opened in somecases.
* chore: bump chromium in DEPS to 144.0.7514.0 * chore: update patches * 7119882: Reorganize //ui/gfx GN build target https://chromium-review.googlesource.com/c/chromium/src/+/7119882 * Replace includes with forward declares in rect_conversions.h https://chromium-review.googlesource.com/c/chromium/src/+/7127098 * Add ssl info to TrustedHeaderClient https://chromium-review.googlesource.com/c/chromium/src/+/7106780 * Replace ContentPluginInfo with WebPluginInfo https://chromium-review.googlesource.com/c/chromium/src/+/7127893 * Reland "[temporal] Unflag Temporal" https://chromium-review.googlesource.com/c/v8/v8/+/7123876 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Update macOS version support in README Support for macOS 11 (BigSur) was removed from v38: https://www.electronjs.org/blog/electron-38-0#removed-macos-11-support
* chore: bump chromium in DEPS to 144.0.7520.0 * chore: fixup patch indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* feat: support WebSocket authentication handling * test: add a test * refactor: route through login instead
* feat: add bypassCustomProtocolHandlers option to net.request * style: fix lint errors in api-protocol-spec
* build: generate artifact attestions for released assets * chore: address review feedback --------- Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
…9645) * Revert "fix: fix Windows MSIX release build errors (#49613)" This reverts commit 4b5d5f9. * refactor: use WRL ComPtr pattern for MSIX to avoid exception handling The MSIX auto-updater code was using C++/WinRT (winrt::* namespace), which requires exception handling (/EHsc). Mixing exception and non-exception handling code in the same binary is problematic at runtime. This commit refactors electron_api_msix_updater.cc to use an upstream Chromium pattern and eliminates the need for special exception handling build flags * build: import correct packages * build: consolidate IPackage declarations * refactor: use IPackageManager/IPackageManager5/IPackageManager9 and IPackage/IPackage2/IPackage4/IPackage6 interfaces as needed for different API methods. Also consolidates duplicate completion handler logic, fixes a bug in RegisterRestartOnUpdate where the command line string could go out of scope, and removes unused includes.
* feat: add support for disclaiming utility processes * chore: update patches --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
docs: add missing type links in menu.md and shared-texture.md
…r audio capture used in electron's `desktopCapturer` (🍏 macOS). (#49717) * fix: Enable CoreAudio Tap API for Audio Capture (🍏 macOS) * fix: addressed markdown issue which caused pre-commit hook failure 🧑🔧 : Ref : #49717 (comment) * fix: updated docs to cover `desktopCapturer` nuances with macOS 📝 : PR #49717
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.32.1 to 4.32.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@6bc82e0...45cbd0c) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.32.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fix 40 typos across 25 documentation files including misspellings, missing words, doubled words, wrong words, and grammatical errors.
* build: fixup attestation for release assets * Generate artifact attestation for generated artifacts * set id-token for attestation * Add artifact-metadata permission for attestation * add permissions for testing attestations * Revert "add permissions for testing attestations" This reverts commit 0284bed. * Revert "set id-token for attestation" This reverts commit 69a1b13. * Revert "Generate artifact attestation for generated artifacts" This reverts commit ee0536e.
…across 1 directory (#49666) build(deps): bump diff in the npm_and_yarn group across 1 directory Bumps the npm_and_yarn group with 1 update in the / directory: [diff](https://github.com/kpdecker/jsdiff). Updates `diff` from 3.5.0 to 3.5.1 - [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md) - [Commits](kpdecker/jsdiff@v3.5.0...v3.5.1) --- updated-dependencies: - dependency-name: diff dependency-version: 3.5.1 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add support for `long-animation-frame` script attribution * docs: document `AlwaysLogLOAFURL` * chore: add test * docs: adjust docs as per PR comment * fix: test failures * chore: simplify test * fix: tests on Windows and Linux
* chore: bump chromium in DEPS to 146.0.7652.0 * fix(patch-conflict): update mas_avoid_private_macos_api_usage context for constrainFrameRect method The upstream CL added a new constrainFrameRect:toScreen: method override to NativeWidgetMacNSWindow as part of headless mode window zoom implementation. The MAS patch's #endif for frameViewClassForStyleMask now correctly appears after that method, since constrainFrameRect is a public API override that doesn't need to be guarded. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7487666 * fix(patch-conflict): update printing.patch for base::DictValue rename Updated printing.patch to use the new base::DictValue type name instead of base::Value::Dict following Chromium's type renaming change. This affects CompleteUpdatePrintSettings() signature and related code. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509820 * fix(patch-conflict): update accessibility_ui patch for base::DictValue/ListValue rename Updated adjust_accessibility_ui_for_electron.patch to use the new base::DictValue and base::ListValue type names instead of base::Value::Dict and base::Value::List following Chromium's type renaming change. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509820 * chore: update patches * 6625736: Rename DURABLE_STORAGE to PERSISTENT_STORAGE for consistency | https://chromium-review.googlesource.com/c/chromium/src/+/6625736 * chore: bump chromium in DEPS to 146.0.7653.0 * chore: update patches * 7000847: add type tag to v8::External for gin_helper function templates The upstream gin function templates now use v8::ExternalPointerTypeTag for type safety when using v8::External. Updated Electron's forked gin_helper function template to use the same kGinInternalCallbackHolderBaseTag that Chromium's gin uses. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7000847 * fix(patch-update): extend V8 Object API deprecation patch for Node.js Extended the existing patch to cover additional files that use GetAlignedPointerFromInternalField and SetAlignedPointerInInternalField: - src/stream_base-inl.h - src/udp_wrap.cc - src/js_udp_wrap.cc - src/node_process_methods.cc - src/node_snapshotable.cc - src/base_object.cc These APIs now require an EmbedderDataTypeTag parameter. Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7087956 * 7000847: add type tag to v8::External calls in shared_texture Updated v8::External::New and v8::External::Value calls to use the kExternalPointerTypeTagDefault tag as required by the V8 API change that deprecates the tagless versions. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7000847 * 7508687: use ChildProcessId for file permission APIs The ChildProcessSecurityPolicy::CanReadFile and GrantReadFile APIs now require ChildProcessId instead of int. Updated to use GetID() instead of GetDeprecatedID() for these specific calls. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7508687 * 7000847: add type tag to v8::External calls in callback and osr_converter The v8::External API now requires an EmbedderPointerTypeTag parameter for both New() and Value() methods to improve V8 sandbox type safety. Updated calls in: - callback.cc: TranslatorHolder constructor and CallTranslator - osr_converter.cc: OffscreenSharedTextureValue converter Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7000847 * fixup! 7087956: [api] Promote deprecation of v8::Context and v8::Object API methods Extended the Node.js patch to cover histogram.cc which also uses SetAlignedPointerInInternalField and GetAlignedPointerFromInternalField APIs that now require the EmbedderDataTypeTag parameter. Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7087956 * chore: bump chromium in DEPS to 146.0.7655.0 * chore: update patches * 7509043: update WebSpellingMarker type for API change The upstream Chromium API changed - WebSpellingMarker was moved from a nested type within WebTextCheckClient to a standalone type in the blink namespace. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509043 * 7498491: update process_id to use OriginatingProcess type The upstream Chromium API changed - URLLoaderFactoryParams::process_id was changed from an integer to a union type network::OriginatingProcess that distinguishes between browser and renderer processes. - For browser process requests, use OriginatingProcess::browser() - For renderer process lookups, check !is_browser() and use renderer_process().value() to get the child_id Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7498491 * 5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception | https://chromium-review.googlesource.com/c/chromium/src/+/5710330 5710330 added a new NSNextStepFrame interface extension and implementations for NativeWidgetMacNSWindowTitledFrame and NativeWidgetMacNSWindowBorderlessFrame. These use private macOS APIs that are not available in Mac App Store builds. * chore: update patches * chore: bump chromium in DEPS to 146.0.7661.0 * chore: bump chromium in DEPS to 146.0.7663.0 * fix(patch-conflict): update accessibility_ui for string_view API change Upstream removed redundant std::string(default_api_type) conversion as part of a string_view optimization cleanup. Updated patch context to match. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7514107 * fix(patch-conflict): update service process launch options for sandbox API refactor Upstream removed content/common/sandbox_init_win.cc and content/public/common/sandbox_init_win.h, moving the functionality directly into ChildProcessLauncherHelper. Updated patch to call sandbox::policy::SandboxWin::StartSandboxedProcess directly with the LaunchOptions pointer instead of going through the removed helper. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7528253 * fix(patch-conflict): update MAS safestorage for keychain API refactor Upstream refactored KeychainPassword::GetPassword() to use a new GetPasswordImpl() helper function with improved error tracking via base::expected<std::string, OSStatus>. Adapted patch to use the new GetPasswordImpl with the suffixed account name and handle migration from legacy accounts through the new API. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7516438 * chore: update patches * chore: bump chromium in DEPS to 146.0.7663.0 * fix: base::Value::Dict -> base::DictValue https://chromium-review.googlesource.com/c/chromium/src/+/7513889 * fix: include new cookie exclusion reason https://chromium-review.googlesource.com/c/chromium/src/+/7486527 * fix: enable libc++ ABI flag for trivially copyable std::vector<bool> Required for changes introduced in the following CL https://chromium-review.googlesource.com/c/chromium/src/+/7513653 * fixup! fix: base::Value::Dict -> base::DictValue https://chromium-review.googlesource.com/c/chromium/src/+/7513889 * fix: spellcheck not working in tests https://chromium-review.googlesource.com/c/chromium/src/+/7452579 * fix: cookie test failing due to multiple rejection reasons https://chromium-review.googlesource.com/c/chromium/src/+/7506629 * fix: macos sizing unmaximized window incorrectly https://chromium-review.googlesource.com/c/chromium/src/+/7487666 Changes to headless mode caused the unmaximized window to subtract the height of the menubar. * fix: skip tests for incompatible BoringSSL ML-DSA crypto https://boringssl-review.googlesource.com/c/boringssl/+/84929 * test: fix pseudonymization registration in utility process on Linux Ref: 7486913: Pass pseudonymization salt via shared memory at process launch | https://chromium-review.googlesource.com/c/chromium/src/+/7486913 * fix: restore MAS patch-outs Restores some `#if !IS_MAS_BUILD()` gates dropped in 773054a * fixup! 7508687: use ChildProcessId for file permission APIs * fixup! fix(patch-conflict): update MAS safestorage for keychain API refactor * chore: add note about parallel upstream change * fixup! Merge remote-tracking branch 'origin/main' into roller/chromium/main * Revert "fixup! 7508687: use ChildProcessId for file permission APIs" This reverts commit 05c43e4. The _impl version has the signature, but not the public interface. :oof: * fixup! fix(patch-conflict): update MAS safestorage for keychain API refactor --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org> Co-authored-by: clavin <clavin@electronjs.org>
* feat: improve Windows Toast actions support * fix: ensure MSIX compatibility * test: add bad clsid format test
* chore: cherry-pick e045399a1ecb from chromium * chore: update patch
* chore: bump node in DEPS to v24.13.1 * chore: fixup patches refs: * nodejs/node#60425 * nodejs/node#61270 * nodejs/node#61044 * fix: generate_config_gypi needs to generate valid JSON nodejs/node#60794 * doc: align Buffer.concat documentation with behavior nodejs/node#60405 * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 * build: fix extraneous includes --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Edvan de Matos <edvan.santos@querodelivery.com>
* feat: support Freedesktop Secret Service OSCrypt client Refs https://issues.chromium.org/issues/40086962 Refs https://issues.chromium.org/issues/447372315 * chore: rework to async interface * refactor: allow customizing freedesktop config * docs: add more async impl info * refactor: reject when temporarily unavailable * chore: feedback from review * chore: push_back => emplace_back
* fix: excise abort_report_np usage in MAS * chore: fix it harder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )