Feat/nostradamus acceleration #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redfast00
reviewed
Apr 13, 2025
src/main/java/telraam/logic/positioner/nostradamus/v2/Nostradamus.java
Outdated
Show resolved
Hide resolved
Topvennie
requested review from
NuttyShrimp
and removed request for
NuttyShrimp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146
Closes #125
Despite the branch name, this does not add acceleration to Nostradamus.
It simplifies and improves the existing Nostradamus slightly.
The version of last year is moved and renamed to
nostradamus_v1. It can be removed after this edition when we know for certain that the new one is better.I've also added a stationary positioner. The idea behind it being that we can switch to that positioner for the start of the race along side a message in loxsi "calibrating positioner" and once we know that the positioners no longer jump around we can switch to them.