Style updates #1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| node_modules | ||
| .env |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,41 @@ | ||
| .Blockquote { | ||
| font-size: 1.6rem; | ||
| margin: 0; | ||
| display: flex; | ||
| align-items: center; | ||
| margin: 1.7rem 0; | ||
| } | ||
|
|
||
| .Blockquote__text { | ||
| text-align: center; | ||
| font-style: oblique; | ||
| font-family: Raleway, sans-serif; | ||
| font-weight: 200; | ||
| margin: 20px auto; | ||
| padding: 14px; | ||
| position: relative; | ||
| border-top: 3px solid #d476d4; | ||
| border-bottom: 3px solid violet; | ||
| transform: rotate(-1.2deg); | ||
| } | ||
|
|
||
| .Blockquote__text::before { | ||
| font-style: initial; | ||
| content: '‟'; | ||
| font-size: 5rem; | ||
| position: absolute; | ||
| top: -2rem; | ||
| left: -2rem; | ||
| color: #cdcdcd; | ||
| } | ||
|
|
||
| .Blockquote__text::after { | ||
| font-style: initial; | ||
| content: '‟'; | ||
| font-size: 5rem; | ||
| position: absolute; | ||
| bottom: -2rem; | ||
| right: -2rem; | ||
| color: #cdcdcd; | ||
| transform: rotate(180deg); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import React, { Fragment } from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| import './styles.css'; | ||
|
Member
Author
There was a problem hiding this comment. Create an issue for styled components |
||
| import classnames from 'classnames'; | ||
|
|
||
|
|
||
| const CountBadge = ({ | ||
| children, | ||
| hideCount, | ||
|
|
||
| isAttached, | ||
| fillColor, | ||
| strokeColor, | ||
| size, | ||
| }) => { | ||
| const count = | ||
| children > 99 ? ( | ||
|
Member
Author
There was a problem hiding this comment. Magic numbers. Replace with |
||
| <Fragment> | ||
| 99<sup>+</sup> | ||
| </Fragment> | ||
| ) : ( | ||
| children | ||
| ); | ||
| return ( | ||
| <div | ||
| className={classnames([ | ||
| 'CountBadge', | ||
| { | ||
| 'CountBadge__is-attached': isAttached, | ||
| }, | ||
| ])} | ||
| style={{ | ||
| color: strokeColor, | ||
| backgroundColor: fillColor, | ||
| fontSize: size / 2, | ||
| height: size, | ||
| width: size, | ||
| }} | ||
| title={children} | ||
| > | ||
| {hideCount ? null : count} | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| CountBadge.propTypes = { | ||
| hideCount: PropTypes.bool, | ||
| children: PropTypes.string.isRequired, | ||
| strokeColor: PropTypes.string, | ||
| fillColor: PropTypes.string, | ||
| size: PropTypes.number, | ||
| }; | ||
|
|
||
| CountBadge.defaultProps = { | ||
| hideCount: false, | ||
| isAttached: false, | ||
| strokeColor: '#ffffff', | ||
| fillColor: '#d01c1c', | ||
| size: 24, | ||
| }; | ||
|
|
||
| export default CountBadge; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| .CountBadge { | ||
| align-items: center; | ||
| border-radius: 100%; | ||
| display: flex; | ||
| font-weight: bold; | ||
| justify-content: center; | ||
| margin: 1px; | ||
| position: relative; | ||
| } | ||
|
|
||
| .CountBadge__is-attached { | ||
| position: absolute; | ||
| top: 0; | ||
| right: 0; | ||
| transform: translate(55%, -55%); | ||
|
Member
Author
There was a problem hiding this comment. I feel that this relies on the outer element having a position relative which doesn't encapsulate this component - it creates a dependency on the outside world rather than being atomic. Options:
Obviously option 2 will have a impact on performance, so should consider looking at stifling re-renders. For now, let's remove this feature and open an issue to investigate and add. |
||
| } | ||
|
|
||
| .CountBadge::after { | ||
|
Member
Author
There was a problem hiding this comment. Can we leave some more comments in the CSS as to what the intent of the pseudo class is. |
||
| border-radius: 100%; | ||
| border: 0.18em solid; | ||
|
Member
Author
There was a problem hiding this comment. Can we need an explicit |
||
| bottom: -1px; /* -1px on position to tackle background colour fuzzing */ | ||
| content: ''; | ||
| left: -1px; | ||
| position: absolute; | ||
| right: -1px; | ||
| top: -1px; | ||
| } | ||
|
|
||
| sup { | ||
| transform: translateY(-20%); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| .HR { | ||
| width: 90%; | ||
| border: none; | ||
| background-color: #ffc600; | ||
| height: 2px; | ||
| transform: rotate(-0.4deg); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| .Input { | ||
| font-family: Raleway, sans-serif; | ||
| font-size: 1rem; | ||
| margin-top: 0.4rem; | ||
| border: 1px solid black; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| .P { | ||
| font-family: Raleway, sans-serif; | ||
| font-weight: 400; | ||
| line-height: 1.5; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* bottom border grows to fill entire background */