stateful API #11
Open
stateful API #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this stuffs most pointer badness into extern "C" blocks
adam-azarchs
approved these changes
May 27, 2021
Author
|
@adam-azarchs thanks! I really appreciate the detailed review. |
use reinterpret/static cast and other minor niggles from review
adam-azarchs
reviewed
Jun 9, 2021
adam-azarchs
reviewed
Jun 9, 2021
Main change here is to not bin-pack arguments. Also add a clang-tidy config.
and visibility fixes for visual studio
fixes for compilation under Visual Studio
Also update makefile to use c++17, as that's what we're using on the rust side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a little gross, but it moves tsne into two stages: initialization and optimization. The reason for this is to support an interruptible server that can at least halt optimization soon-ish when it receives a such a request.