Skip to content

Conversation

@theafolayan
Copy link

This pull request updates the React Native HMS Android module to improve compatibility with React Native 0.81 by ensuring that event and command maps are returned as MutableMap instances. It also refactors the usage of the current activity throughout HMSManager to consistently use reactApplicationContext.currentActivity, which is a more reliable way to access the current activity in React Native modules.

React Native 0.81 compatibility improvements

  • Updated getExportedCustomDirectEventTypeConstants, getExportedCustomBubblingEventTypeConstants, and getCommandsMap in HMSHLSPlayerManager and HMSSDKViewManager to wrap maps with HashMap, ensuring the returned type matches the expected MutableMap signature for React Native 0.81. [1] [2] [3] [4] [5]

Activity access refactoring

  • Replaced all instances of currentActivity with reactApplicationContext.currentActivity in HMSManager, making activity access more robust and preventing potential null pointer issues. This change affects PIP registration, screenshare, audioshare, and lifecycle callback registration/unregistration. [1] [2] [3] [4] [5] [6] [7] [8] [9]

@theafolayan theafolayan requested a review from ygit as a code owner November 6, 2025 18:08
@trunk-io
Copy link

trunk-io bot commented Nov 6, 2025

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@trunk-io
Copy link

trunk-io bot commented Nov 6, 2025

An error occurred while submitting your PR to the queue: Only users that are a part of this repo's Trunk organization or have write permissions to the repo can submit a PR to the queue

@theafolayan
Copy link
Author

@gzerad @s-dvd This is costing our Business Money!!

@theafolayan
Copy link
Author

@ygit , please look into this and approve so we can have access to the FIX!

We're a paying customer FGS and you're all acting non-challant while we have to scramble for solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant