Add more handler tests #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new test to verify that we get the expected error upon an invalid authorization event in the get_blob handler. Also adds a new ConfigBuilder builder to make it easy to test different configurations while also keeping the code clean and easy to read.
Adds tempfile as a dependency. This will be used in tests for creating temporary directories used to store the database and files in tests.
Adds two new tests for the get blob handler. One test verifies that we get a 404 whenever we request a blob with an invalid file hash in the url path. The other test verifies that we get a 404 whenever we try to get a file where we don't find a matching blob descriptor. I've also simplified the blob descriptor query code a bit to make it more readable and less verbose. I've also refactored the set_up_app_state function in the handler tests to use the tempfile dependency instead. I did this because tempfile will delete the temporary folder whenever the temp_dir goes out of scope, i.e. it cleans up after each test so we don't get any side effects from other tests. This also brings a change to the function signature as we have to return the temp_dir to ensure that the variable isn't dropped and the temp folder deleted. If that were to happen, we wouldn't be able to read from it anymore.
Validates that an invalid auth event in a /list/pubkey request returns a 401 response.
Adds test to verify that an upload with a non-whitelisted mimetype is rejected with a 415 UNSUPPORTED_MEDIA_TYPE response.
Adds a test to verify that an UNAUTHORIZED response is returned when the delete blob handler is handed an invalid auth event.
Adds a test to verify that an UNAUTHORIZED response is returned when the mirror blob handler is handed an invalid auth event.
Moves the get blob handler tests up to the first get blob handler test, just to keep the code clean and tidy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for handler methods