Bebop #455
Merged
Bebop #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he `packed_commands` field
Propagate changes from Mainnet to fix Solidity diamond inheritance: - Change _isRestrictedTarget from pure to view in TakerSubmitted - Add _isRestrictedTarget override in MetaTxn resolving inheritance - Add _isRestrictedTarget override in Intent resolving inheritance 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Test basic swap, slippage check, slippage failure, and partial fills - Verify ecrecover is called with correctly computed EIP-712 digest - Mock only ecrecover precompile; all other Bebop logic runs for real - Test both WETH→USDC and USDC→WETH directions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Rename Bebop.t.sol to BebopPairTest.t.sol as a mixin - Integrate BebopPairTest into USDC_WETH and WETH_USDC test suites - Remove standalone concrete test contracts - Add allowanceHolder approval to BebopPairTest.setUp() - Update gas snapshots to use standard pair naming convention 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Verify that BASIC action reverts with ConfusedDeputy() when attempting to call restricted targets: Bebop, Permit2, and AllowanceHolder. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- BebopOrder.flags replaced with event_id (uint128) - partnerId is now always zero (Settler doesn't pass it to Bebop) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fix compilation errors caused by diamond inheritance of _isRestrictedTarget from multiple base classes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
e1Ru1o
approved these changes
Dec 23, 2025
Use vm.sign(MAKER_PRIVATE_KEY, digest) to create actual EIP-712 signatures instead of mocking the ecrecover precompile. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nicob87
reviewed
Dec 26, 2025
…, and HyperEVM 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
@nicob87 I updated the PR to include support on all the listed chains. I need to size-golf the Base SettlerIntent some before we deploy, but the functionality is all there. |
nicob87
approved these changes
Dec 29, 2025
e1Ru1o
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.