Ankit/add buy voucher with permit #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new method to delegate amounts using a permit, along with a helper method to generate the permit signature data.
- Added delegateAmountPOLwithPermit in validator_share.ts, which internally calls buyVoucherWithPermit.
- Added getPermitData in matic_token.ts to generate permit signature data and updated import dependencies for TYPE_AMOUNT and Converter.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/contracts/validator_share.ts | Added delegateAmountPOLwithPermit to handle delegation with permit for POL tokens. |
| src/contracts/matic_token.ts | Added getPermitData to generate permit data and updated imports to support new types and utilities. |
Files not reviewed (1)
- package.json: Language not supported
src/contracts/matic_token.ts
Outdated
| amount: TYPE_AMOUNT, | ||
| spender: string | ||
| ): Promise<{ v: number; r: string; s: string; deadline: number }> { | ||
| debugger |
There was a problem hiding this comment.
Remove the 'debugger' statement to avoid unintended breakpoints in production code.
Suggested change
| debugger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.