Skip to content

feat: migrate e2e tests#316

Merged
temaniarpit27 merged 60 commits intodevelopfrom
arpit/aggkit-329
May 14, 2025
Merged

feat: migrate e2e tests#316
temaniarpit27 merged 60 commits intodevelopfrom
arpit/aggkit-329

Conversation

@temaniarpit27
Copy link
Copy Markdown

@temaniarpit27 temaniarpit27 commented Apr 3, 2025

@temaniarpit27 temaniarpit27 changed the base branch from main to develop April 3, 2025 11:41
@temaniarpit27 temaniarpit27 force-pushed the arpit/aggkit-329 branch 3 times, most recently from 7a1df89 to 3c394b5 Compare May 6, 2025 01:51
Base automatically changed from arpit/325-2 to arpit/aggkit-409 May 9, 2025 11:06
Base automatically changed from arpit/aggkit-409 to develop May 9, 2025 13:14
Copy link
Copy Markdown
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the Makefile, as the commands are outdated (

cdk/test/Makefile

Lines 7 to 27 in 9471868

.PHONY: test-e2e-fork9-validium
test-e2e-fork9-validium: stop
./run-e2e.sh fork9 cdk-validium
bats bats/
.PHONY: test-e2e-fork11-rollup
test-e2e-fork11-rollup: stop
./run-e2e.sh fork11 rollup
bats bats/
.PHONY: test-e2e-fork12-validium
test-e2e-fork12-validium: stop
./run-e2e.sh fork12 cdk-validium
# this is for fail fast if kurtosis fails to deploy cdk-node-001
kurtosis service inspect cdk cdk-node-001
bats bats/
.PHONY: test-e2e-fork12-rollup
test-e2e-fork12-rollup: stop
./run-e2e.sh fork12 rollup
bats bats/
)

@temaniarpit27
Copy link
Copy Markdown
Author

temaniarpit27 commented May 13, 2025

Update the Makefile, as the commands are outdated (

cdk/test/Makefile

Lines 7 to 27 in 9471868

.PHONY: test-e2e-fork9-validium
test-e2e-fork9-validium: stop
./run-e2e.sh fork9 cdk-validium
bats bats/
.PHONY: test-e2e-fork11-rollup
test-e2e-fork11-rollup: stop
./run-e2e.sh fork11 rollup
bats bats/
.PHONY: test-e2e-fork12-validium
test-e2e-fork12-validium: stop
./run-e2e.sh fork12 cdk-validium
# this is for fail fast if kurtosis fails to deploy cdk-node-001
kurtosis service inspect cdk cdk-node-001
bats bats/
.PHONY: test-e2e-fork12-rollup
test-e2e-fork12-rollup: stop
./run-e2e.sh fork12 rollup
bats bats/

)

we dont need this now as we have moved to another script
removed in upcoming PR

Copy link
Copy Markdown
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@rachit77 rachit77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sonarqubecloud
Copy link
Copy Markdown

@temaniarpit27 temaniarpit27 merged commit 29a7a12 into develop May 14, 2025
15 checks passed
@temaniarpit27 temaniarpit27 deleted the arpit/aggkit-329 branch May 14, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants