Skip to content

fix: transaction type not supported bumping go-ethereum to 1.15.5#306

Merged
joanestebanr merged 8 commits intorelease/v0.5.xfrom
fix/transaction_type_not_supported
Mar 10, 2025
Merged

fix: transaction type not supported bumping go-ethereum to 1.15.5#306
joanestebanr merged 8 commits intorelease/v0.5.xfrom
fix/transaction_type_not_supported

Conversation

@joanestebanr
Copy link
Copy Markdown
Contributor

@joanestebanr joanestebanr commented Mar 7, 2025 •
edited
Loading

Description

It fix the issue transaction type not supported that is fixed on library zkevm-synchronizer-l1@v1.0.7 but if requires to bump go-ethereum and go versions

@joanestebanr joanestebanr self-assigned this Mar 7, 2025
@joanestebanr joanestebanr added dependencies Pull requests that update a dependency file aggregator seqsender and removed seqsender labels Mar 7, 2025
rachit77
rachit77 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rachit77 rachit77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Stefan-Ethernal
Stefan-Ethernal approved these changes Mar 10, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just let's create a new version of zkevm eth tx manager and use that version here.

@Stefan-Ethernal
Copy link
Copy Markdown
Collaborator

Stefan-Ethernal commented Mar 10, 2025

Ok already done, I'm lagging a couple of seconds 😃

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 10, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joanestebanr joanestebanr merged commit 1734557 into release/v0.5.x Mar 10, 2025
14 checks passed
@joanestebanr joanestebanr deleted the fix/transaction_type_not_supported branch March 10, 2025 12:12
@deepalIGD
Copy link
Copy Markdown

deepalIGD commented Mar 11, 2025 •
edited
Loading

Hi guys @joanestebanr , may I ask what is the change on the CDK side? The synchronizer more specifically.
I can see that the geth version has been bumped up to Geth v1.15.5. But is there some change on the synchronizer to handle the events that came from the deposit contract, which caused the Pectra issue?
In the following commits, could you point me to the LOC that mitigates the issue?
0xPolygon/zkevm-synchronizer-l1@d8ff257#diff-7a6724a7a7d2b4f15f0fba180e9585cd0e2dc084b66fe613b1b33e71f595dfd8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToniRamirezM ToniRamirezM ToniRamirezM approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

+3 more reviewers

@vcastellm vcastellm vcastellm approved these changes

@temaniarpit27 temaniarpit27 temaniarpit27 approved these changes

@rachit77 rachit77 rachit77 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joanestebanr joanestebanr

Labels

aggregator dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@joanestebanr @Stefan-Ethernal @deepalIGD @vcastellm @temaniarpit27 @rachit77 @ToniRamirezM @goran-ethernal