feat: remove syncers and import the aggkit by rachit77 · Pull Request #256 · 0xPolygon/cdk

rachit77 · 2025-01-07T13:19:38Z

Description

This PR removes syncers (bridge syncer, last ger syncer, claim sponsor), bridge service, and other relevant packages for aggkit repo migration.

config/default.go

rpc/bridge.go

Stefan-Ethernal · 2025-02-06T13:34:43Z

Should we reuse the following packages from the aggkit as well (and remove it from the cdk):

db,
etherman (partially),
hex,
log

* remove aggoracle component * improve Rust build perf and cleanup * handle error when unmarashaling versions.json

* remove aggsender component * fix: remove build-tools

* mockery generate * Update .mockery.yaml Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * review comments * review comment --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>

rachit77 · 2025-02-11T12:11:23Z

Should we reuse the following packages from the aggkit as well (and remove it from the cdk):

db,

etherman (partially),

hex,

log

Removed db, hex and log. For etherman maybe we need discuss how we want to tackle this

Stefan-Ethernal · 2025-02-11T14:42:29Z

Just to put a reminder here:
we should remove the bridge rpc implementation logic from the CDK (https://github.com/0xPolygon/cdk/blob/327a72f495a7f4ef27138cf58ec629bc8c2e30ac/rpc/bridge.go), but we might want to instantiate the one from the aggkit repository (TBD). The same applies to the aggsender component.

…etector l2 and corresponding config params)

sonarqubecloud · 2025-02-14T08:58:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

* feat: remove `aggoracle` component (#251) * remove aggoracle component * improve Rust build perf and cleanup * handle error when unmarashaling versions.json * feat: remove `aggsender` component (#252) * remove aggsender component * fix: remove build-tools * feat: mockery generate (#255) * mockery generate * Update .mockery.yaml Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * review comments * review comment --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * wip * feat: fix BuildVersions during cargo build (#258) * fix DAC imports * remove unused code * chore: remove empty docker-compose.yml * fix build.rs * remove hex package * remove log package * remove db package * go mod tidy and fix in the proof * chore: remove redundant file * feat: remove bridge service (feat. claim sponsor, bridgesync, reorg detector l2 and corresponding config params) * chore: format and fix docs * chore: move bats e2e tests from fep folder * fix: path for batch_verification_monitor script --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> Co-authored-by: Arpit Temani <temaniarpit27@gmail.com> Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com> Co-authored-by: Stefan Negovanović <stefan@ethernal.tech>

* feat: remove `aggoracle` component (#251) * remove aggoracle component * improve Rust build perf and cleanup * handle error when unmarashaling versions.json * feat: remove `aggsender` component (#252) * remove aggsender component * fix: remove build-tools * fix: improve JSON parsing by cleaning up version strings * feat: mockery generate (#255) * mockery generate * Update .mockery.yaml Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * review comments * review comment --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * rebase fix * feat: remove syncers and import the aggkit (#256) * feat: remove `aggoracle` component (#251) * remove aggoracle component * improve Rust build perf and cleanup * handle error when unmarashaling versions.json * feat: remove `aggsender` component (#252) * remove aggsender component * fix: remove build-tools * feat: mockery generate (#255) * mockery generate * Update .mockery.yaml Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * review comments * review comment --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * wip * feat: fix BuildVersions during cargo build (#258) * fix DAC imports * remove unused code * chore: remove empty docker-compose.yml * fix build.rs * remove hex package * remove log package * remove db package * go mod tidy and fix in the proof * chore: remove redundant file * feat: remove bridge service (feat. claim sponsor, bridgesync, reorg detector l2 and corresponding config params) * chore: format and fix docs * chore: move bats e2e tests from fep folder * fix: path for batch_verification_monitor script --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> Co-authored-by: Arpit Temani <temaniarpit27@gmail.com> Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com> Co-authored-by: Stefan Negovanović <stefan@ethernal.tech> --------- Co-authored-by: Arpit Temani <temaniarpit27@gmail.com> Co-authored-by: Rachit Sonthalia <54906134+rachit77@users.noreply.github.com> Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>

rachit77 changed the title ~~Removes syncers for aggkit migration~~ feat: removes syncers for aggkit migration Jan 7, 2025

rachit77 marked this pull request as draft January 7, 2025 13:22

rachit77 self-assigned this Jan 10, 2025

rachit77 marked this pull request as ready for review January 10, 2025 14:52

rachit77 requested a review from goran-ethernal January 10, 2025 14:52

Stefan-Ethernal force-pushed the feat/aggkit-repo-migration branch from 79c94e2 to 04b8363 Compare January 21, 2025 11:37

Stefan-Ethernal mentioned this pull request Jan 21, 2025

feat: aggkit repo migration #253

Merged

3 tasks

Stefan-Ethernal force-pushed the rachit77/remove-syncers branch from d814581 to ac8d966 Compare January 27, 2025 10:51

rachit77 requested a review from a team January 28, 2025 14:15

goran-ethernal reviewed Feb 3, 2025

View reviewed changes

config/default.go Show resolved Hide resolved

rpc/bridge.go Outdated Show resolved Hide resolved

Stefan-Ethernal force-pushed the feat/aggkit-repo-migration branch from baa4aaa to 7116e38 Compare February 4, 2025 14:50

Stefan-Ethernal and others added 8 commits February 10, 2025 01:36

feat: remove aggoracle component (#251)

3d4be0e

* remove aggoracle component * improve Rust build perf and cleanup * handle error when unmarashaling versions.json

feat: remove aggsender component (#252)

5d32d87

* remove aggsender component * fix: remove build-tools

wip

327a72f

feat: fix BuildVersions during cargo build (#258)

6f7fd29

fix DAC imports

800570f

remove unused code

5c8d613

chore: remove empty docker-compose.yml

1cd27ec

rachit77 force-pushed the rachit77/remove-syncers branch from 327487e to 1cd27ec Compare February 11, 2025 09:55

rachit77 added 4 commits February 11, 2025 17:00

fix build.rs

591ec99

remove hex package

65f2536

remove log package

82d7a0f

remove db package

e0a8330

Stefan-Ethernal added 2 commits February 11, 2025 15:00

go mod tidy and fix in the proof

569ca08

chore: remove redundant file

6ce5bd2

feat: remove bridge service (feat. claim sponsor, bridgesync, reorg d…

9e9d7d9

…etector l2 and corresponding config params)

chore: format and fix docs

5fc9102

Stefan-Ethernal requested a review from goran-ethernal February 14, 2025 07:39

Stefan-Ethernal changed the title ~~feat: removes syncers for aggkit migration~~ feat: remove syncers for aggkit migration Feb 14, 2025

goran-ethernal approved these changes Feb 14, 2025

View reviewed changes

chore: move bats e2e tests from fep folder

db48385

Stefan-Ethernal force-pushed the rachit77/remove-syncers branch from 42750b5 to db48385 Compare February 14, 2025 08:26

fix: path for batch_verification_monitor script

6543356

Stefan-Ethernal approved these changes Feb 14, 2025

View reviewed changes

Stefan-Ethernal changed the title ~~feat: remove syncers for aggkit migration~~ feat: remove syncers and import the aggkit Feb 14, 2025

ToniRamirezM approved these changes Feb 17, 2025

View reviewed changes

vcastellm approved these changes Feb 18, 2025

View reviewed changes

Stefan-Ethernal merged commit aed13f5 into feat/aggkit-repo-migration Feb 18, 2025

Stefan-Ethernal deleted the rachit77/remove-syncers branch February 18, 2025 08:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove syncers and import the aggkit#256

feat: remove syncers and import the aggkit#256
Stefan-Ethernal merged 18 commits intofeat/aggkit-repo-migrationfrom
rachit77/remove-syncers

rachit77 commented Jan 7, 2025 •

edited by Stefan-Ethernal

Loading

Uh oh!

Uh oh!

Uh oh!

Stefan-Ethernal commented Feb 6, 2025

Uh oh!

rachit77 commented Feb 11, 2025 •

edited

Loading

Uh oh!

Stefan-Ethernal commented Feb 11, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Feb 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

rachit77 commented Jan 7, 2025 • edited by Stefan-Ethernal Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Uh oh!

Uh oh!

Stefan-Ethernal commented Feb 6, 2025

Uh oh!

rachit77 commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Stefan-Ethernal commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 14, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rachit77 commented Jan 7, 2025 •

edited by Stefan-Ethernal

Loading

rachit77 commented Feb 11, 2025 •

edited

Loading

Stefan-Ethernal commented Feb 11, 2025 •

edited

Loading