Conversation
Stefan-Ethernal
left a comment
Stefan-Ethernal
left a comment
There was a problem hiding this comment.
Generally LGTM.
| func getClient() (*ethclient.Client, error) { | ||
| return ethclient.Dial("http://localhost:8545") | ||
| } |
There was a problem hiding this comment.
Probably doesn't deserve a separate function for this. WDYT?
Also as a side note, would it be an overkill if we were starting up the mock l1 network in case it is not running already?
| if err != nil { | ||
| return err | ||
| } | ||
| os.Geteuid() |
There was a problem hiding this comment.
Is this line a leftover?
| os.Geteuid() |
| return errors.New("failed to fund account") | ||
| } | ||
|
|
||
| return err |
There was a problem hiding this comment.
Optional nitpick (it is probably just slightly better, in terms of readability being explicit here, but as you prefer at the end of the day)
| return err | |
| return nil |
| @@ -0,0 +1,18 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
WDYT about reusing this script here as well
cdk-contracts-tooling/cmd/importcontracts.go
Lines 204 to 210 in 7f18da0
| &cli.PathFlag{ | ||
| Name: setupDACFilePathFlagName, | ||
| Aliases: []string{"f"}, | ||
| Usage: `File path of a JSON that looks like {"requiredSingatures": X, "members": [{"address": "0x...", "url": "http://..."}]}`, |
There was a problem hiding this comment.
| Usage: `File path of a JSON that looks like {"requiredSingatures": X, "members": [{"address": "0x...", "url": "http://..."}]}`, | |
| Usage: `File path of a JSON that looks like {"requiredSignatures": X, "members": [{"address": "0x...", "url": "http://..."}]}`, |
Probably it would be a good idea providing a JSON example as it is done for the wallets and rpcs toml files?
| } | ||
| fmt.Printf(` | ||
| DAC Configuration: | ||
| required signatures %d / %d. |
There was a problem hiding this comment.
| required signatures %d / %d. | |
| Required signatures %d / %d. |
Feature/rollupman ops
Feature/deploy rollup manager
|
2 participants
Uh oh!
There was an error while loading. Please reload this page.