feat: add grok imagine as image generation#1516
Open
lmariscal wants to merge 1 commit into0xPlaygrounds:mainfrom
Open
feat: add grok imagine as image generation#1516lmariscal wants to merge 1 commit into0xPlaygrounds:mainfrom
lmariscal wants to merge 1 commit into0xPlaygrounds:mainfrom
Conversation
bec7a53 to
80337c1
Compare
80337c1 to
c6ca431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grok-imagine-imageandgrok-imagine-image-promodels)ImageGenerationModeltrait for the xAI provider, following the same pattern as OpenAI's implementationaspect_ratioandresolutioninstead of pixel-basedsize, so these are passed viaadditional_params(defaults to"1:1"aspect ratio)Changes
rig-core/src/providers/xai/image_generation.rs— New module implementing theImageGenerationModeltrait for xAIrig-core/src/providers/xai/mod.rs— Register and re-export theimage_generationmodule (behindimagefeature flag)rig-core/src/providers/xai/client.rs— ChangeImageGeneration = NothingtoCapable<ImageGenerationModel<H>>rig-core/examples/xai_image_generation.rs— Example demonstrating usage with custom resolution and aspect ratioTest plan
cargo clippy --example xai_image_generation --features imagepassescargo test --lib -p rig-corepassesFixes #1517