Skip to content

feat(rig-sqlite): impl InsertDocuments trait for sqlite#1478

Open
howenyap wants to merge 1 commit into0xPlaygrounds:mainfrom
howenyap:feat/insert-documents-sqlite
Open

feat(rig-sqlite): impl InsertDocuments trait for sqlite#1478
howenyap wants to merge 1 commit into0xPlaygrounds:mainfrom
howenyap:feat/insert-documents-sqlite

Conversation

@howenyap
Copy link

@howenyap howenyap commented Mar 6, 2026

Changes

  • implements InsertDocuments trait for rig-sqlite, part of feat: impl InsertDocuments for all vector store providers #565
  • updated documentation comments to use insert_documents
  • updated outdated top_n call here
  • added integration test to cover insert_documents
  • updated sqlite connection to be in memory only, there are only two tests now but this would make tests less flaky in the future, in case we have leftover rows from previous runs (lmk if i should remove this)

@howenyap howenyap force-pushed the feat/insert-documents-sqlite branch from b3d36fa to 505d0f9 Compare March 9, 2026 16:30
@howenyap
Copy link
Author

howenyap commented Mar 9, 2026

hm errors are unrelated to my changes, all pointing towards the gemini client

saw some changes to client in the main branch so i rebased, not sure if it'll fix the errors

@howenyap
Copy link
Author

howenyap commented Mar 9, 2026

verified that previously failing actions now pass locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant