feat(rig-1197): handle llama.cpp tool call (#1408)#1409
Open
inqode-lars wants to merge 1 commit into0xPlaygrounds:mainfrom
Open
feat(rig-1197): handle llama.cpp tool call (#1408)#1409inqode-lars wants to merge 1 commit into0xPlaygrounds:mainfrom
inqode-lars wants to merge 1 commit into0xPlaygrounds:mainfrom
Conversation
Signed-off-by: Lars Weber <lars@inqode.solutions>
joshua-mo-143
requested changes
Feb 21, 2026
Collaborator
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
See comments. Rest looks ok to me
Comment on lines
+413
to
+424
| fn deserialize_arguments<'de, D>(deserializer: D) -> Result<Value, D::Error> | ||
| where | ||
| D: Deserializer<'de>, | ||
| { | ||
| let value = Value::deserialize(deserializer)?; | ||
|
|
||
| match value { | ||
| Value::String(s) => serde_json::from_str(&s).map_err(serde::de::Error::custom), | ||
| other => Ok(other), | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
please add docstring to explain why this is required (it's not immediately clear to anyone who reads this in the future if they don't refer back to this PR)
| pub name: String, | ||
| #[serde(with = "json_utils::stringified_json")] | ||
| #[serde( | ||
| serialize_with = "json_utils::stringified_json::serialize", |
Collaborator
There was a problem hiding this comment.
Is this correct? It seems to have been perfectly fine before to my knowledge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle llama.cpp tool call
closes #1408