feat: implement on_before_asset_added_to_note callback#2595
Open
PhilippGackstatter wants to merge 11 commits intopgackst-asset-callbacksfrom
Open
feat: implement on_before_asset_added_to_note callback#2595PhilippGackstatter wants to merge 11 commits intopgackst-asset-callbacksfrom
on_before_asset_added_to_note callback#2595PhilippGackstatter wants to merge 11 commits intopgackst-asset-callbacksfrom
Conversation
PhilippGackstatter
force-pushed
the
pgackst-note-callback
branch
from
cb8638c to
8c8cab0
Compare
bobbinth
approved these changes
Mar 14, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left just one optional comment inline.
crates/miden-protocol/asm/kernels/transaction/lib/callbacks.masm
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements:
NonFungibleAssets.on_before_asset_added_to_notecallback.It follows the same pattern as established in #2571.
closes #2432