-
Notifications
You must be signed in to change notification settings - Fork 121
feat(agglayer): process CLAIM notes from a rollup #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmagician
wants to merge
12
commits into
agglayer
Choose a base branch
from
mmagician-claude/rollup-claims
base: agglayer
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
487124e
feat(agglayer): process CLAIM notes from a rollup
claude cb4627e
refactor: extract leading zeros/flag validation from global index hel…
claude 39890f2
chore: regenerate agglayer error constants
claude 0b8834f
fix: use non-zero indices in rollup test vectors and fix stack bug
claude 85c3ea7
refactor: use distinct error messages for mainnet/rollup flag validation
claude 654ca3c
fix: clarify mainnet flag comment and add ERR_MAINNET_FLAG_INVALID test
claude 0764c3d
fix: remove stale constant reference and useless inline test
claude 3e04f7b
refactor: unify GlobalIndex validation and reject invalid flag values
claude 9ce0425
refactor: define memory pointers relative to existing constants
claude 66de26d
refactor: regroup and document memory layout constants
claude 4fa6069
Apply suggestions from code review
mmagician 8dfdc5c
Fix rollup deposit merkle proof stack setup (#2576)
mmagician File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
crates/miden-agglayer/solidity-compat/test-vectors/claim_asset_vectors_rollup_tx.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| { | ||
| "amount": "100000000000000000000", | ||
| "deposit_count": 3, | ||
| "description": "Rollup deposit test vectors with valid two-level Merkle proofs (non-zero indices)", | ||
| "destination_address": "0x00000000AA0000000000bb000000cc000000Dd00", | ||
| "destination_network": 20, | ||
| "global_exit_root": "0x677d4ecba0ff4871f33163e70ea39a13fe97f2fa9b4dbad110e398830a324159", | ||
| "global_index": "0x0000000000000000000000000000000000000000000000000000000500000002", | ||
| "leaf_type": 0, | ||
| "leaf_value": "0x4a6a047a2b89dd9c557395833c5e34c4f72e6f9aae70779e856f14a6a2827585", | ||
| "local_exit_root": "0x985cff7ee35794b30fba700b64546b4ec240d2d78aaf356d56e83d907009367f", | ||
| "mainnet_exit_root": "0x4d63440b08ffffe5a049aae4161d54821a09973965a1a1728534a0f117b6d6c9", | ||
| "metadata": "0x000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000012000000000000000000000000000000000000000000000000000000000000000a5465737420546f6b656e0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000045445535400000000000000000000000000000000000000000000000000000000", | ||
| "metadata_hash": "0x4d0d9fb7f9ab2f012da088dc1c228173723db7e09147fe4fea2657849d580161", | ||
| "origin_network": 3, | ||
| "origin_token_address": "0x2DC70fb75b88d2eB4715bc06E1595E6D97c34DFF", | ||
| "rollup_exit_root": "0x91105681934ca0791f4e760fb1f702050d81e4b7c866d42f540710999c90ea97", | ||
| "smt_proof_local_exit_root": [ | ||
| "0x0000000000000000000000000000000000000000000000000000000000000000", | ||
| "0xa8367b4263332f7e5453faa770f07ef4ce3e74fc411e0a788a98b38b91fd3b3e", | ||
| "0xb4c11951957c6f8f642c4af61cd6b24640fec6dc7fc607ee8206a99e92410d30", | ||
| "0x21ddb9a356815c3fac1026b6dec5df3124afbadb485c9ba5a3e3398a04b7ba85", | ||
| "0xe58769b32a1beaf1ea27375a44095a0d1fb664ce2dd358e7fcbfb78c26a19344", | ||
| "0x0eb01ebfc9ed27500cd4dfc979272d1f0913cc9f66540d7e8005811109e1cf2d", | ||
| "0x887c22bd8750d34016ac3c66b5ff102dacdd73f6b014e710b51e8022af9a1968", | ||
| "0xffd70157e48063fc33c97a050f7f640233bf646cc98d9524c6b92bcf3ab56f83", | ||
| "0x9867cc5f7f196b93bae1e27e6320742445d290f2263827498b54fec539f756af", | ||
| "0xcefad4e508c098b9a7e1d8feb19955fb02ba9675585078710969d3440f5054e0", | ||
| "0xf9dc3e7fe016e050eff260334f18a5d4fe391d82092319f5964f2e2eb7c1c3a5", | ||
| "0xf8b13a49e282f609c317a833fb8d976d11517c571d1221a265d25af778ecf892", | ||
| "0x3490c6ceeb450aecdc82e28293031d10c7d73bf85e57bf041a97360aa2c5d99c", | ||
| "0xc1df82d9c4b87413eae2ef048f94b4d3554cea73d92b0f7af96e0271c691e2bb", | ||
| "0x5c67add7c6caf302256adedf7ab114da0acfe870d449a3a489f781d659e8becc", | ||
| "0xda7bce9f4e8618b6bd2f4132ce798cdc7a60e7e1460a7299e3c6342a579626d2", | ||
| "0x2733e50f526ec2fa19a22b31e8ed50f23cd1fdf94c9154ed3a7609a2f1ff981f", | ||
| "0xe1d3b5c807b281e4683cc6d6315cf95b9ade8641defcb32372f1c126e398ef7a", | ||
| "0x5a2dce0a8a7f68bb74560f8f71837c2c2ebbcbf7fffb42ae1896f13f7c7479a0", | ||
| "0xb46a28b6f55540f89444f63de0378e3d121be09e06cc9ded1c20e65876d36aa0", | ||
| "0xc65e9645644786b620e2dd2ad648ddfcbf4a7e5b1a3a4ecfe7f64667a3f0b7e2", | ||
| "0xf4418588ed35a2458cffeb39b93d26f18d2ab13bdce6aee58e7b99359ec2dfd9", | ||
| "0x5a9c16dc00d6ef18b7933a6f8dc65ccb55667138776f7dea101070dc8796e377", | ||
| "0x4df84f40ae0c8229d0d6069e5c8f39a7c299677a09d367fc7b05e3bc380ee652", | ||
| "0xcdc72595f74c7b1043d0e1ffbab734648c838dfb0527d971b602bc216c9619ef", | ||
| "0x0abf5ac974a1ed57f4050aa510dd9c74f508277b39d7973bb2dfccc5eeb0618d", | ||
| "0xb8cd74046ff337f0a7bf2c8e03e10f642c1886798d71806ab1e888d9e5ee87d0", | ||
| "0x838c5655cb21c6cb83313b5a631175dff4963772cce9108188b34ac87c81c41e", | ||
| "0x662ee4dd2dd7b2bc707961b1e646c4047669dcb6584f0d8d770daf5d7e7deb2e", | ||
| "0x388ab20e2573d171a88108e79d820e98f26c0b84aa8b2f4aa4968dbb818ea322", | ||
| "0x93237c50ba75ee485f4c22adf2f741400bdf8d6a9cc7df7ecae576221665d735", | ||
| "0x8448818bb4ae4562849e949e17ac16e0be16688e156b5cf15e098c627c0056a9" | ||
| ], | ||
| "smt_proof_rollup_exit_root": [ | ||
| "0x0000000000000000000000000000000000000000000000000000000000000000", | ||
| "0xad3228b676f7d3cd4284a5443f17f1962b36e491b30a40b2405849e597ba5fb5", | ||
| "0xb4c11951957c6f8f642c4af61cd6b24640fec6dc7fc607ee8206a99e92410d30", | ||
| "0x21ddb9a356815c3fac1026b6dec5df3124afbadb485c9ba5a3e3398a04b7ba85", | ||
| "0xe58769b32a1beaf1ea27375a44095a0d1fb664ce2dd358e7fcbfb78c26a19344", | ||
| "0x0eb01ebfc9ed27500cd4dfc979272d1f0913cc9f66540d7e8005811109e1cf2d", | ||
| "0x887c22bd8750d34016ac3c66b5ff102dacdd73f6b014e710b51e8022af9a1968", | ||
| "0xffd70157e48063fc33c97a050f7f640233bf646cc98d9524c6b92bcf3ab56f83", | ||
| "0x9867cc5f7f196b93bae1e27e6320742445d290f2263827498b54fec539f756af", | ||
| "0xcefad4e508c098b9a7e1d8feb19955fb02ba9675585078710969d3440f5054e0", | ||
| "0xf9dc3e7fe016e050eff260334f18a5d4fe391d82092319f5964f2e2eb7c1c3a5", | ||
| "0xf8b13a49e282f609c317a833fb8d976d11517c571d1221a265d25af778ecf892", | ||
| "0x3490c6ceeb450aecdc82e28293031d10c7d73bf85e57bf041a97360aa2c5d99c", | ||
| "0xc1df82d9c4b87413eae2ef048f94b4d3554cea73d92b0f7af96e0271c691e2bb", | ||
| "0x5c67add7c6caf302256adedf7ab114da0acfe870d449a3a489f781d659e8becc", | ||
| "0xda7bce9f4e8618b6bd2f4132ce798cdc7a60e7e1460a7299e3c6342a579626d2", | ||
| "0x2733e50f526ec2fa19a22b31e8ed50f23cd1fdf94c9154ed3a7609a2f1ff981f", | ||
| "0xe1d3b5c807b281e4683cc6d6315cf95b9ade8641defcb32372f1c126e398ef7a", | ||
| "0x5a2dce0a8a7f68bb74560f8f71837c2c2ebbcbf7fffb42ae1896f13f7c7479a0", | ||
| "0xb46a28b6f55540f89444f63de0378e3d121be09e06cc9ded1c20e65876d36aa0", | ||
| "0xc65e9645644786b620e2dd2ad648ddfcbf4a7e5b1a3a4ecfe7f64667a3f0b7e2", | ||
| "0xf4418588ed35a2458cffeb39b93d26f18d2ab13bdce6aee58e7b99359ec2dfd9", | ||
| "0x5a9c16dc00d6ef18b7933a6f8dc65ccb55667138776f7dea101070dc8796e377", | ||
| "0x4df84f40ae0c8229d0d6069e5c8f39a7c299677a09d367fc7b05e3bc380ee652", | ||
| "0xcdc72595f74c7b1043d0e1ffbab734648c838dfb0527d971b602bc216c9619ef", | ||
| "0x0abf5ac974a1ed57f4050aa510dd9c74f508277b39d7973bb2dfccc5eeb0618d", | ||
| "0xb8cd74046ff337f0a7bf2c8e03e10f642c1886798d71806ab1e888d9e5ee87d0", | ||
| "0x838c5655cb21c6cb83313b5a631175dff4963772cce9108188b34ac87c81c41e", | ||
| "0x662ee4dd2dd7b2bc707961b1e646c4047669dcb6584f0d8d770daf5d7e7deb2e", | ||
| "0x388ab20e2573d171a88108e79d820e98f26c0b84aa8b2f4aa4968dbb818ea322", | ||
| "0x93237c50ba75ee485f4c22adf2f741400bdf8d6a9cc7df7ecae576221665d735", | ||
| "0x8448818bb4ae4562849e949e17ac16e0be16688e156b5cf15e098c627c0056a9" | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.