Skip to content

fix: remove middle step serialization for InputNoteCommitment #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SantiagoPittella wants to merge 1 commit into from
Closed

fix: remove middle step serialization for InputNoteCommitment #1793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions crates/proto/src/domain/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use miden_protocol::Word;
use miden_protocol::note::Nullifier;
use miden_protocol::transaction::{InputNoteCommitment, TransactionId};
use miden_protocol::utils::serde::{Deserializable, Serializable};

use crate::errors::{ConversionError, MissingFieldHelper};
use crate::generated as proto;
Expand Down Expand Up @@ -85,13 +84,6 @@ impl TryFrom<proto::transaction::InputNoteCommitment> for InputNoteCommitment {
let header: Option<miden_protocol::note::NoteHeader> =
value.header.map(TryInto::try_into).transpose()?;

// TODO: https://github.com/0xMiden/node/issues/1783
// InputNoteCommitment has private fields, so we reconstruct it via
// serialization roundtrip using its Serializable/Deserializable impls.
let mut bytes = Vec::new();
nullifier.write_into(&mut bytes);
header.write_into(&mut bytes);
InputNoteCommitment::read_from_bytes(&bytes)
.map_err(|err| ConversionError::deserialization_error("InputNoteCommitment", err))
Ok(InputNoteCommitment::from_parts_unchecked(nullifier, header))
}
}
Loading