Conversation
5eab224 to
d9d058a
Compare
|
I have not yet read through this, but I don't think we can actively remove the |
SantiagoPittella
left a comment
There was a problem hiding this comment.
Did not review it yet, but tried running docker-compose up and got this errors:
rpc-1 exited with code 2
ntx-builder-1 exited with code 2
block-producer-1 exited with code 2
validator-1 exited with code 2
You can get the logs of the containers to determine why they exited. But you do need to run |
My intention with this PR is to have it working against the integration test suite so it will at least be working for local dev use case. As for deployment to devnet, yea we need to make sure we merge this at a moment that makes sense in terms of our planned releases. All seems to work but I don't know which commit to match miden-client test suite against node next. So I'm not able to verify the test suite atm. |
Makes sense; I think I expected there to be more work to physically decouple the components reliably at startup. But maybe there is less than I thought. Something we also need to check on is |
https://github.com/search?q=repo:0xMiden/midenup%20bundled&type=code We just need to replace this with a series of commands (like the ones in the readmes in this PR). |
|
Could we possibly split the deprecation of |
Context
We want to replace the bundled command with a docker-compose deployment for local development.
Closes #1765.
Changes
bundledcommand which ran all components in a single processntx-builderas a standalone CLI subcommanddocker-compose.ymlwith individual services: store, validator, block-producer, rpc, ntx-buildergenesiscompose profile that wipes volumes and bootstraps a fresh networkmake compose-genesis(wipe + bootstrap),make compose-up(start),make compose-down(stop),make compose-logs(follow logs)