Skip to content

Replace bundled command with compose#1786

Open
sergerad wants to merge 6 commits intonextfrom
sergerad-replace-bundled
Open

Replace bundled command with compose#1786
sergerad wants to merge 6 commits intonextfrom
sergerad-replace-bundled

Conversation

@sergerad
Copy link
Collaborator

@sergerad sergerad commented Mar 12, 2026

Context

We want to replace the bundled command with a docker-compose deployment for local development.

Closes #1765.

Changes

  • Remove the bundled command which ran all components in a single process
  • Add ntx-builder as a standalone CLI subcommand
  • Add docker-compose.yml with individual services: store, validator, block-producer, rpc, ntx-builder
  • Add a separate genesis compose profile that wipes volumes and bootstraps a fresh network
  • Update Makefile: make compose-genesis (wipe + bootstrap), make compose-up (start), make compose-down (stop), make compose-logs (follow logs)

@sergerad sergerad marked this pull request as ready for review March 12, 2026 06:09
@sergerad sergerad requested review from Mirko-von-Leipzig and SantiagoPittella and removed request for Mirko-von-Leipzig March 12, 2026 06:09
Base automatically changed from sergerad-validator-bootstrap to next March 12, 2026 06:16
@sergerad sergerad force-pushed the sergerad-replace-bundled branch from 5eab224 to d9d058a Compare March 12, 2026 06:49
@Mirko-von-Leipzig
Copy link
Collaborator

I have not yet read through this, but I don't think we can actively remove the bundled command just yet, until we are extremely certain that all things work correctly as separate components.

Copy link
Collaborator

@SantiagoPittella SantiagoPittella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not review it yet, but tried running docker-compose up and got this errors:

rpc-1 exited with code 2
ntx-builder-1 exited with code 2
block-producer-1 exited with code 2
validator-1 exited with code 2

@sergerad
Copy link
Collaborator Author

Did not review it yet, but tried running docker-compose up and got this errors:

rpc-1 exited with code 2
ntx-builder-1 exited with code 2
block-producer-1 exited with code 2
validator-1 exited with code 2

You can get the logs of the containers to determine why they exited. But you do need to run make compose-genesis first.

@sergerad
Copy link
Collaborator Author

sergerad commented Mar 12, 2026

I have not yet read through this, but I don't think we can actively remove the bundled command just yet, until we are extremely certain that all things work correctly as separate components.

My intention with this PR is to have it working against the integration test suite so it will at least be working for local dev use case. As for deployment to devnet, yea we need to make sure we merge this at a moment that makes sense in terms of our planned releases.

All seems to work but I don't know which commit to match miden-client test suite against node next. So I'm not able to verify the test suite atm.

@Mirko-von-Leipzig
Copy link
Collaborator

I have not yet read through this, but I don't think we can actively remove the bundled command just yet, until we are extremely certain that all things work correctly as separate components.

My intention with this PR is to have it working against the integration test suite so it will at least be working for local dev use case. As for deployment to devnet, yea we need to make sure we merge this at a moment that makes sense in terms of our planned releases.

All seems to work but I don't know which commit to match miden-client test suite against node next. So I'm not able to verify the test suite atm.

Makes sense; I think I expected there to be more work to physically decouple the components reliably at startup. But maybe there is less than I thought.

Something we also need to check on is midenup which I believe incorporates the node in some capacity. So switching from a single binary to a docker compose would likely break them. I'm unsure who to ping for that.

@sergerad
Copy link
Collaborator Author

sergerad commented Mar 15, 2026

Something we also need to check on is midenup which I believe incorporates the node in some capacity. So switching from a single binary to a docker compose would likely break them. I'm unsure who to ping for that.

https://github.com/search?q=repo:0xMiden/midenup%20bundled&type=code

We just need to replace this with a series of commands (like the ones in the readmes in this PR).

@drahnr
Copy link
Contributor

drahnr commented Mar 16, 2026

Could we possibly split the deprecation of bundled from the introduction of the containerized all-in-one deployment option? That way we can actively dog-feed this with little friction while retaining bundled until we're confident to deploy it to devnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace bundled command

4 participants