Open
Conversation
TomasArrachea
force-pushed
the
tomasarrachea-store-api-keys
branch
from
608a390 to
c97864a
Compare
SantiagoPittella
approved these changes
Feb 13, 2026
Collaborator
SantiagoPittella
left a comment
SantiagoPittella
left a comment
There was a problem hiding this comment.
LGTM, added some nits
CHANGELOG.md
Outdated
|
|
||
| ## 0.14.0 (TBD) | ||
|
|
||
| - Removed `--api-key` param from the `start` command, API keys are now persisted in the store and automatically loaded on startup. ([#225](https://github.com/0xMiden/miden-faucet/pull/225)). |
Collaborator
There was a problem hiding this comment.
Mark this as breaking
bin/faucet/src/main.rs
Outdated
Comment on lines
+131
to
+138
| #[arg(long = "store", value_name = "FILE", default_value = "faucet_client_store.sqlite3", env = ENV_STORE)] | ||
| store_path: PathBuf, | ||
| }, | ||
|
|
||
| /// Remove an API key from the store. | ||
| RemoveApiKey { | ||
| /// Path to the `SQLite` store. | ||
| #[arg(long = "store", value_name = "FILE", default_value = "faucet_client_store.sqlite3", env = ENV_STORE)] |
Collaborator
There was a problem hiding this comment.
We should probably move "faucet_client_store.sqlite3" to a constant
bin/faucet/src/main.rs
Outdated
Comment on lines
+370
to
+372
| for key in keys { | ||
| println!("{}", key.encode()); | ||
| } |
Collaborator
There was a problem hiding this comment.
If the vector is empty lets print something like "No API keys found"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
This PR:
create-api-keycommand so that it persists the created API key in the storelist-api-keysandremove-api-keycommandsThe keys are stored in the settings table as a single setting value. Each time the list gets updated, the whole list of keys is loaded and updated in the store.