feat: use SSE for issuance#224
Open
TomasArrachea wants to merge 2 commits intotomasarrachea-retrieve-issuancefrom
Open
feat: use SSE for issuance#224TomasArrachea wants to merge 2 commits intotomasarrachea-retrieve-issuancefrom
TomasArrachea wants to merge 2 commits intotomasarrachea-retrieve-issuancefrom
Conversation
TomasArrachea
force-pushed
the
tomasarrachea-sse-on-issuance
branch
from
66c0009 to
defc5d5
Compare
TomasArrachea
force-pushed
the
tomasarrachea-sse-on-issuance
branch
from
defc5d5 to
6962802
Compare
TomasArrachea
force-pushed
the
tomasarrachea-retrieve-issuance
branch
from
9f31dd4 to
efd23da
Compare
Comment on lines
+22
to
+23
| let stream = WatchStream::new(server.issuance_receiver) | ||
| .map(|value| Ok(Event::default().event("issuance").data(value.base_units().to_string()))); |
Collaborator
There was a problem hiding this comment.
I'm a bit unfamiliar with this, not really sure how this is being updated. Also, this is sent to the clients at every update, right?
Collaborator
Author
There was a problem hiding this comment.
Right, after each minting the faucet updates the issuance value and clients get sent an update event though this stream.
Before, clients had to poll the metadata endpoint instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #97.
This PR removes the metadata polling made by the frontend and replaces it with a new issuance SSE endpoint. This endpoint sends an event each time the issuance gets updated, that is triggered after each mint.