chore(Internal): Remove the superseded cmp_keys#902
Open
iamrecursion wants to merge 1 commit intonextfrom
Open
chore(Internal): Remove the superseded cmp_keys#902iamrecursion wants to merge 1 commit intonextfrom
cmp_keys#902iamrecursion wants to merge 1 commit intonextfrom
Conversation
iamrecursion
added
the
no changelog
This function was superseded by the change in #847 to have `Word` compare lexicographically. This commit removes the last few uses and replaces them with calls to the `Ord` implementation for `Word` instead, simplifying the codebase.
iamrecursion
force-pushed
the
remove-cmp-keys
branch
from
d9ab79e to
9770799
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This function was superseded by the change in #847 to have
Wordcompare lexicographically. This commit removes the last few uses and replaces them with calls to theOrdimplementation forWordinstead, simplifying the codebase.Closes #901. No changelog because the function was never public-facing.
Checklist before requesting a review
nextaccording to naming convention.