enhance(LargeSmtForest tests): expand LargeSmtForest property test coverage#886
Open
AlexWaker wants to merge 4 commits into0xMiden:nextfrom
Open
enhance(LargeSmtForest tests): expand LargeSmtForest property test coverage#886AlexWaker wants to merge 4 commits into0xMiden:nextfrom
AlexWaker wants to merge 4 commits into0xMiden:nextfrom
Conversation
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the property-based test coverage for
LargeSmtForest.Previously, the forest-level property tests were mostly limited to
entries(). This change adds a broader set of reference-model-driven property tests covering core query, mutation, metadata, constructor, and truncation behavior.The new tests now exercise:
get(),entries(), andentry_count()open()consistency checks against a referenceSmtlatest_version(),latest_root(),lineage_roots(),roots(), androot_info()add_lineage(),update_tree(), andupdate_forest()with_config()andtruncate()In addition, the property test helpers and generators were refactored to make the coverage easier to extend and maintain.
Closes #879.