Inline stubs

[djolertrk]

Do it in two phases:

1. Detect and register all linker stubs first (ensures that when we translate function bodies in pass all stubs are known and calls to them will be inlined regard less of function ordering in the WASM file)
2. Do the inlining

[bitwalker]

@djolertrk Is this ready? Looks like you just need to update the expect tests that are failing (since the handling of stubs has changed), but once that is done, I'm guessing there isn't much more planned for this PR correct?

[greenhat]

Looking good when the stub ends up being an op!
I did not find how the stdlib/tx_kernel function calls transformation is preserved.

[greenhat]

maybe_lower_linker_stub handles cases where the stub is transformed to call the stdlib/tx_kernel function. See for example

compiler/tests/integration/expected/examples/p2id.wat

Lines 707 to 715 in e8de1ae

	(func $miden::active_account::get_id (;27;) (type 6) (param i32)
	unreachable
	)
	(func $miden::active_note::get_assets (;28;) (type 11) (param i32) (result i32)
	unreachable
	)
	(func $miden::active_note::get_inputs (;29;) (type 11) (param i32) (result i32)
	unreachable
	)

transformed into

compiler/tests/integration/expected/examples/p2id.hir

Lines 1253 to 1276 in e8de1ae

	private builtin.function @miden::active_account::get_id(v864: i32) {
	^block107(v864: i32):
	v865, v866 = hir.exec @miden/active_account/get_id() : felt, felt
	v867 = hir.bitcast v864 : u32;
	v868 = hir.int_to_ptr v867 : ptr<byte, felt>;
	hir.store v868, v865;
	v869 = arith.constant 4 : u32;
	v870 = arith.add v867, v869 : u32 #[overflow = checked];
	v871 = hir.int_to_ptr v870 : ptr<byte, felt>;
	hir.store v871, v866;
	builtin.ret ;
	};
	private builtin.function @miden::active_note::get_assets(v872: i32) -> i32 {
	^block111(v872: i32):
	v873, v874 = hir.exec @miden/active_note/get_assets(v872) : i32, i32
	builtin.ret v873;
	};
	private builtin.function @miden::active_note::get_inputs(v876: i32) -> i32 {
	^block114(v876: i32):
	v877, v878 = hir.exec @miden/active_note/get_inputs(v876) : i32, i32
	builtin.ret v877;
	};

I don't see them handled anywhere after the deletion of this call.

[greenhat]

Look good!

[greenhat]

@djolertrk The first commit is without a signature. Please sign.

[greenhat]

As a side note, github does not send a notification on PR status change (draft -> ready) so when I get a notification for a new commit I'm not sure if it's ready for review. Re-requesting review or ping in a comment is appreciated since it ends up as a notification in my inbox.