Fix #175: simply add Ghost colliding logic#176
Closed
unknownersamli wants to merge 526 commits into0x0ade:ghost-fixesfrom
Closed
Fix #175: simply add Ghost colliding logic#176unknownersamli wants to merge 526 commits into0x0ade:ghost-fixesfrom
unknownersamli wants to merge 526 commits into0x0ade:ghost-fixesfrom
Conversation
…time-out before reconnect
…st name format to be legal names again
and choose better Guest name first, then always do optional numbers afterwards as before
…rval to 0, which isn't allowed.
Ability for Tab Suggestions to be canceled/hidden
…choosing the two parts
…ather than space-stripped name
Changing that guest-name-change logging from DEV to INF
Guest client identifiers
Log conn tokens until we fix the generator setup
…release as v2.2.1
… to hopefully avoid some hard to debug crashes people have been having when disconnecting at the wrong time.
…y name) when it exists, instead of 'username'. Also hide discriminator '0' that shows up on users transitioned to unique usernames
…changes Use the 'global_name' from Discord API's JSON
oops I broke discord auth, good thing we did testing in production :)
…, hope noone minds
…pace or channel name that is just the private prefix.
…ements. Some of the outputs might still be a bit clunky, and needs testing.
…f ParseAndRun to get exception-based command errors always.
…reported to player, and how they're listed.
… something I tried earlier.
Use `Ordinal` instead of `InvariantCulture` comparison
…tion from WaitFor doesn't cause the TaskCompletionSource from WaitForAsync to get canceled as well
…of Server setting. If multiple connection attempts fail and Server is not the DefaultServer, a button pops up right below the Connect toggle to connect back to official default server.
…ow 'Reload Extra Servers' button then as well, so initially you'd have to add some by config editing.
…ld've happened. EffectiveServer is a property that takes the override into account but does not get saved to YAML, as I intended it. If in the next month someone has 'Server: localhost' in their config, it'll be reset because it may have been the oopsie. But at least with the new mod option labels and warning it'll be noticable either way.
…tiveServer setter since that's private anyway
Clarify "Connect" option and show prompt to fix failing attempts to connect to non-default servers.
…& Shared (0x0ade#154) * check the description of the PR ( 0x0ade#154) if anything is unclear about this squash'd merge.
…iewport and leave Engine.Viewport alone
* Enable nullable context in Client project and fixed all(?) nullable-related warnings in it. * Introduce 'null-safe' extensions for checking common ButtonBinding properties
…er-maybe Adjust CelesteNetRenderHelper IL to avoid Engine.Viewport issues
…nnection (0x0ade#164) * Only throw exceptions in DataContext.Read that will kill a connection when the DataType originates from CelesteNet itself. From other mods, just log the exception... * Same for WriteAll as for ReadAll -- only throw exceptions when it is CelesteNet's own DataType, otherwise just log the error.
…hey're caused by other mods' data
…on-other-mods Use custom exception during data read/writes and just log them when they're caused by other mods' data
(adds ModInterop exports + ) Session-Level Interactions Override
Collaborator
|
How did you branch this off of PR #29, and somehow you're trying to merge everything that has happened on the main branch in the last 3 years back into that ghost-fixes branch?... Can you start out on "main" and make your branch on that and open a new PR? Edit: Your one commit, a86eb8f also seems to change nothing, as far as I can tell |
Author
|
My bad, I didn't reconize something was wrong |
unknownersamli
force-pushed
the
fix/issue-175
branch
from
a86eb8f to
ac1be20
Compare
Author
|
The new pull request is change to #177 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a serious fix but I just wanna reach out my hands