Split ModInterop into multiple interop classes (Exports)#174
Draft
RedFlames wants to merge 1 commit into0x0ade:mainfrom
Draft
Split ModInterop into multiple interop classes (Exports)#174RedFlames wants to merge 1 commit into0x0ade:mainfrom
RedFlames wants to merge 1 commit into0x0ade:mainfrom
Conversation
… of how to maybe structure this. Idk if this should be done differently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still some things on the TODO list that could be exposed.
I'm unsure if this makes sense, or how it should be done differently.
I'm assuming the idea is that someone who only has the Interop and doesn't want to reference our assembly, will then not have classes like DataTypes, Ghosts, ... available, so if any properties of those want to be queried, there needs to be an exported method?
That's why here you can get uint[] arrays of the player IDs, channel IDs, chat msg IDs, ... and then retrieve specific attributes of those via their ID.
Still needs documentation, testing, possibly examples and the structure of the "Import" class of the other side...