Fully ignore DataNetEmoji in Client when avatars are disabled (hide own avatar)#167
Merged
RedFlames merged 1 commit into0x0ade:mainfrom Dec 21, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR of two added lines, but I'm annoyed enough that I had accidentally committed this into #162 to pull it into this. 🤷
This is because someone mentioned in #celestenet they would like to not have their own avatar showing up when own nametag is enabled and avatars are not, and that is indeed a bit of an oversight from when SJ release made me hack in avatar disabling to improve uh, handshake survival rate.